deploy, kustomize: provide an OpenShift overlay

[maiqueb]

Provide an overlay for OpenShift.

[maiqueb]

need to figure out the name of the service here ... the prefix above (line 9) is not playing along here.

maybe consider removing the prefix ?...

[oshoval]

ye no need the prefix imo
fwiw note please that CNAO will know to do it all itself based only on dist/install.yaml

so this PR is needed only if you want to be able to deploy the repo standalone on OCP

i would even suggest the minimalist manifest kustomize if so for this
even seds or easiest possible
no need naming / namespace changes

[maiqueb]

Ah thanks. I had forgotten about that.

Well, it still makes sense, but, the priority surely drops quite a lot.

It would still be useful to test drive the feature early on OpenShift though.

[oshoval]

changing manually only the required bit, the secret need to be "kubevirt-ipam-claims-webhook-service"
maybe you can set it as such for both U/S and D/S
without prefixing stuff (or at least not the secret) and it will work ?

(adapting to kubevirt-ipam-controller-webhook-service once time comes)

[kubevirt-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[kubevirt-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

[kubevirt-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

[kubevirt-bot]

@kubevirt-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[oshoval]

didnt try
but this might work and maybe we can just start by having another manifest dedicated for openshift with some flag etc

https://gist.github.com/oshoval/d5db815ebea60eb1777a838bee0530b9

[oshoval]

worth to add this task to the backlog
for example so we can easily deploy potential fixes on QE clusters for quick checking if a bug is fixed
i.e istio with empty config and #90
quick solution might be to just have the above manifest in addition instead kustomize

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from maiqueb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[maiqueb]

I'll try to ensure this works in OpenShift in the coming days.

[maiqueb]

Superseded by #91