update k8s & related libraries to 1.31 #3625
Conversation
Signed-off-by: Alex Kalenyuk <[email protected]>
kubevirt-bot
added
release-note
kubevirt-bot
added
the
do-not-merge/work-in-progress
Signed-off-by: Alex Kalenyuk <[email protected]>
Signed-off-by: Alex Kalenyuk <[email protected]>
Signed-off-by: Alex Kalenyuk <[email protected]>
akalenyu
force-pushed
the
31-deps-bump
branch
from
ce61649 to
d9c372b
Compare
|
/test all |
1 similar comment
|
/test all |
| "tls.key": []byte(""), | ||
| "tls.crt": []byte(""), |
There was a problem hiding this comment.
@mhenriks this feels so wrong but but not sure if we have alternatives as we must be the ones creating them?
There was a problem hiding this comment.
This doesn't offend me very much
Brace yourself for a rollercoaster: https://github.com/openshift/library-go/blob/release-4.18/pkg/operator/resource/resourceapply/core.go#L452 this path is no longer used since recent library-go. We should be okay since the versions upgrading to this CDI have a secret that was converted to the TLS type Signed-off-by: Alex Kalenyuk <[email protected]>
akalenyu
force-pushed
the
31-deps-bump
branch
from
93c9454 to
b6fe9f0
Compare
|
/test all |
| populateClientAndStoreWithSecrets(client, cm.(*certManager), namespace) | ||
| syncStoreWithLocalUpdateCalls(client, cm.(*certManager), namespace) |
There was a problem hiding this comment.
@mhenriks looks like with this library-go change openshift/library-go#1772 there's additional logic to call the CREATE.
not sure if this messes up functionality (should requeue on already exists err) but it definitely hurts the unit tests
I tried shifting the order a bit but it's clunky. Calling Sync() an extra time also doesn't help, seems like the lister is never updated and thus the library-go mechanism keeps trying to CREATE (which I guess makes sense since it's all fake)
There was a problem hiding this comment.
I got further here but can't help feeling like we're doing something fundamentally wrong because I don't ever recall being in this problem space in kubevirt
(client updates/patches needing to be reflected on the objects in the cache.Store)
There was a problem hiding this comment.
KubeVirt doesn't use this library
context openshift/library-go#1772 Signed-off-by: Alex Kalenyuk <[email protected]>
This reverts commit 9acaa19. Signed-off-by: Alex Kalenyuk <[email protected]>
akalenyu
force-pushed
the
31-deps-bump
branch
from
b6fe9f0 to
5de3246
Compare
|
/test all |
|
/cc @awels |
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
/retest |
|
/test all |
|
/test pull-containerized-data-importer-fossa |
|
/lgtm |
|
/test pull-containerized-data-importer-e2e-nfs |
|
Pull requests that are marked with After that period the bot marks them with the label /label needs-approver-review |
kubevirt-bot
added
the
needs-approver-review
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/remove-label needs-approver-review |
kubevirt-bot
removed
the
needs-approver-review
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: