[WIP] MTV-1699 Avoid potentially exceeding memory limit in multi-stage VDDK imports. #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
kubevirt-bot
added
do-not-merge/work-in-progress
mrnold
changed the title
Storing multiple QueryChangedDiskAreas results could potentially exceed importer pod memory limits, so rework the code to iterate over one result at a time. Signed-off-by: Matthew Arnold <[email protected]>
There is no longer an easily-accessible list of changed blocks to check, so these tests need to let TransferFile run and mock everything that does. Signed-off-by: Matthew Arnold <[email protected]>
MockableStat is a stronger signal for something unusual. Signed-off-by: Matthew Arnold <[email protected]>
Signed-off-by: Matthew Arnold <[email protected]>
Signed-off-by: Matthew Arnold <[email protected]>
This block was preventing the actual data copy in some situations, when it only really needs to avoid the next call to QueryChangedDiskAreas. Move it after the copy. Signed-off-by: Matthew Arnold <[email protected]>
mrnold
force-pushed
the
cbt-query-usage
branch
from
28d3f0e to
b9e949c
Compare
This is mostly cosmetic as the importer pod isn't going to be able to transfer anything anyway, but an error message is nicer than a panic. Signed-off-by: Matthew Arnold <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
From this conversation, this pull request avoids storing all results from QueryChangedDiskAreas during a VDDK warm migration. A disk with a lot of small evenly-spaced changes could get the importer to create a huge list, which might exceed the pod's memory limit. This change iterates over one result from QueryChangedDiskAreas at a time, which so far seems to be limited to 2000 changed extent entries.
Which issue(s) this PR fixes:
Fixes MTV-1699
Special notes for your reviewer:
This is a draft for now while I get this tested more thoroughly.
Release note: