Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Vela uses zstd compression function causing OOM (#92) #93

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

msun1996
Copy link
Contributor

fix the concurrent number of zstd encoders in k8s container and support zstd configuration re-initialization

@charlie0129
Copy link
Member

I think importing go.uber.org/automaxprocs should be enough.

@msun1996
Copy link
Contributor Author

I think importing go.uber.org/automaxprocs should be enough.

I can first import go.uber.org/automaxprocs to solve the existing problem.
You can consider adding it after configuring the zstd compression concurrency number. I think it may have an impact on large batch data processing. At the same time, I will verify the performance impact of this parameter on our service later.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.85%. Comparing base (325c22e) to head (e6bca8d).

❗ Current head e6bca8d differs from pull request most recent head 8d7e39a. Consider uploading reports for the commit 8d7e39a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   87.93%   87.85%   -0.08%     
==========================================
  Files          81       81              
  Lines        3803     3803              
==========================================
- Hits         3344     3341       -3     
- Misses        348      350       +2     
- Partials      111      112       +1     
Flag Coverage Δ
unit-test 87.85% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@charlie0129 charlie0129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please fix the DCO.

@msun1996 msun1996 force-pushed the fix-zstd-compress branch 2 times, most recently from a0b9575 to fc66a5b Compare March 4, 2024 07:32
@msun1996 msun1996 force-pushed the fix-zstd-compress branch from fc66a5b to 8d7e39a Compare March 4, 2024 07:36
@wonderflow wonderflow merged commit cf7ea07 into kubevela:main Mar 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants