Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: update k8s to 1.29 #109

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Chore: update k8s to 1.29 #109

merged 3 commits into from
Dec 3, 2024

Conversation

phantomnat
Copy link
Contributor

@phantomnat phantomnat commented Sep 23, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.63265% with 9 lines in your changes missing coverage. Please review.

Project coverage is 86.60%. Comparing base (eaacca6) to head (f7955d7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
multicluster/remoteclusterclient.go 57.14% 4 Missing and 2 partials ⚠️
util/singleton/client.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   88.41%   86.60%   -1.82%     
==========================================
  Files          81       81              
  Lines        3366     3956     +590     
==========================================
+ Hits         2976     3426     +450     
- Misses        261      398     +137     
- Partials      129      132       +3
Flag Coverage Δ
unit-test 86.60% <81.63%> (-1.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phantomnat phantomnat force-pushed the feat/update-k8s branch 2 times, most recently from 5be4864 to 3161895 Compare September 23, 2024 12:59
@phantomnat phantomnat changed the title feat: upgrade to k8s 1.29 feat: upgrade k8s to 1.29 Sep 23, 2024
@phantomnat phantomnat mentioned this pull request Sep 23, 2024
Open
FogDong
FogDong approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@FogDong FogDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but have you tried testing kubevela with pkg?

@phantomnat
Copy link
Contributor Author

Not yet, will try updating on the workflow and then kubevela

@phantomnat phantomnat marked this pull request as draft September 24, 2024 04:53
@phantomnat phantomnat changed the title feat: upgrade k8s to 1.29 Chore: update k8s to 1.29 Sep 24, 2024
@FogDong
Copy link
Member

FogDong commented Sep 27, 2024

@phantomnat Thanks for the contribution! Feel free to ping me when the tests are passed, looking forward to the k8s update!

@FogDong FogDong mentioned this pull request Nov 5, 2024
Closed
@AiRanthem AiRanthem mentioned this pull request Nov 13, 2024
Closed
@phantomnat
feat: update k8s to 1.29
763908c 
Signed-off-by: phantomnat <[email protected]>
@phantomnat
test: add unit
845f48d 
Signed-off-by: phantomnat <[email protected]>
@phantomnat phantomnat marked this pull request as ready for review November 25, 2024 17:29
wonderflow
wonderflow reviewed Nov 29, 2024
View reviewed changes
controller/client/monitor_client.go
@@ -23,7 +23,6 @@ import (

"github.com/prometheus/client_golang/prometheus"
"k8s.io/apimachinery/pkg/runtime"
"sigs.k8s.io/controller-runtime/pkg/cache"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we remove it? is it because it's deprecated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since client.Options has a way to pass information about the cache and monitorCache only has Get and List.

I decided to change to client.Reader instead.

@wonderflow
Copy link
Contributor

ping @Somefive , @chivalryq

Somefive
Somefive approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@Somefive Somefive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Somefive Somefive merged commit 2cf9877 into kubevela:main Dec 3, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FogDong FogDong FogDong approved these changes

@Somefive Somefive Somefive approved these changes

@wonderflow wonderflow wonderflow approved these changes

@chivalryq chivalryq Awaiting requested review from chivalryq chivalryq is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phantomnat @FogDong @wonderflow @Somefive