Updated node roles in docs #49360

Aaina26 · 2025-01-08T13:20:46Z

netlify · 2025-01-08T13:31:00Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`dca9071`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679b4ca4a337920007e2ae47
😎 Deploy Preview	https://deploy-preview-49360--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim

Thanks. Let's make sure to document the node-role.kubernetes.io/* node label too.

content/en/docs/concepts/architecture/nodes.md

content/en/docs/reference/labels-annotations-taints/_index.md

sftim

How about these changes? They'd align better with the style guide.

However, I also think that making this change as-is makes the docs overall better, so:
/lgtm

content/en/docs/reference/labels-annotations-taints/_index.md

content/en/docs/concepts/architecture/nodes.md

k8s-ci-robot · 2025-01-22T08:25:03Z

LGTM label has been added.

Git tree hash: 5cfe56a8f3df5d112933da799f6e4bcac4dfe5ce

Aaina26 · 2025-01-22T09:29:32Z

Thanks for the suggestions. I have updated the PR to better suite the style guide.

sftim

One more change and this is dead right (see inline feedback)

/lgtm

If we merge this, the docs are less wrong.

sftim · 2025-01-26T14:55:48Z

content/en/docs/concepts/architecture/nodes.md

@@ -140,6 +140,11 @@ When you want to create Node objects manually, set the kubelet flag `--register-
 You can modify Node objects regardless of the setting of `--register-node`.
 For example, you can set labels on an existing Node or mark it unschedulable.

+You can set optional node role(s) for nodes by adding one or more `node-role.kubernetes.io/<role>: <role>` labels to the node where characters of `<role>` 
+are limited by the [syntax](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set) rules for labels.


Suggested change

are limited by the [syntax](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set) rules for labels.

are limited by the [syntax](/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set) rules for labels.

k8s-ci-robot · 2025-01-26T14:56:31Z

LGTM label has been added.

Git tree hash: d2da1cf1d3ff8ef5ce395ab4740a852f9a56e6f0

sftim

/lgtm

k8s-ci-robot · 2025-01-27T10:03:08Z

LGTM label has been added.

Git tree hash: 5733119b5ac6e58e10908f7413db2e2168c5e5d2

network-charles · 2025-01-28T18:48:59Z

content/en/docs/concepts/architecture/nodes.md

+You can set optional node role(s) for nodes by adding one or more `node-role.kubernetes.io/<role>: <role>` labels to the node where characters of `<role>` 
+are limited by the [syntax](/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set) rules for labels.
+
+Kubernetes ignores the label value for node roles;by convention, you can set it to the same string you used for the node role in label key.


Suggested change

Kubernetes ignores the label value for node roles;by convention, you can set it to the same string you used for the node role in label key.

Kubernetes ignores the label value for node roles; by convention, you can set it to the same string you used for the node role in the label key.

I have addressed this in the new commit. Thanks for pointing this out.

You are welcome

Aaina26 · 2025-02-11T05:58:55Z

Hi @sftim and @network-charles..
PTAL

network-charles · 2025-02-11T11:37:58Z

/lgtm

k8s-ci-robot · 2025-02-11T11:38:06Z

LGTM label has been added.

Git tree hash: d82c6e199568f8de4135c3ccb23214fd7c2a6116

sftim

/approve

k8s-ci-robot · 2025-02-16T17:17:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/docs/OWNERS~~ [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Updated node roles in docs

3aefd43

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Jan 8, 2025

k8s-ci-robot requested review from caesarxuchao and salaxander January 8, 2025 13:20

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2025

sftim reviewed Jan 8, 2025

View reviewed changes

content/en/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved

content/en/docs/reference/labels-annotations-taints/_index.md Show resolved Hide resolved

Added entry for

76806ad

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2025

sftim reviewed Jan 22, 2025

View reviewed changes

content/en/docs/reference/labels-annotations-taints/_index.md Outdated Show resolved Hide resolved

content/en/docs/reference/labels-annotations-taints/_index.md Outdated Show resolved Hide resolved

content/en/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved

k8s-ci-robot assigned sftim Jan 22, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025

made changes to better fit style guide

a337ec3

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025

k8s-ci-robot requested a review from sftim January 22, 2025 09:28

sftim reviewed Jan 26, 2025

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2025

slight change in link

df6a3fb

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2025

k8s-ci-robot requested a review from sftim January 26, 2025 16:23

sftim reviewed Jan 27, 2025

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2025

network-charles reviewed Jan 28, 2025

View reviewed changes

fixed slight error in a sentence

dca9071

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2025

k8s-ci-robot requested a review from sftim January 30, 2025 09:55

k8s-ci-robot assigned network-charles Feb 11, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2025

sftim reviewed Feb 16, 2025

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2025

k8s-ci-robot merged commit f80c848 into kubernetes:main Feb 16, 2025
6 checks passed

Eason1118 mentioned this pull request Feb 18, 2025

[zh-cn] sync architecture/nodes.md #49816

Merged

	are limited by the [syntax](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set) rules for labels.
	are limited by the [syntax](/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set) rules for labels.

	Kubernetes ignores the label value for node roles;by convention, you can set it to the same string you used for the node role in label key.
	Kubernetes ignores the label value for node roles; by convention, you can set it to the same string you used for the node role in the label key.

Updated node roles in docs #49360

Updated node roles in docs #49360

Uh oh!

Conversation

Aaina26 commented Jan 8, 2025

Uh oh!

netlify bot commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Pull request preview available for checking

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

k8s-ci-robot commented Jan 22, 2025

Uh oh!

Aaina26 commented Jan 22, 2025

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

sftim Jan 26, 2025

Choose a reason for hiding this comment

Uh oh!

Aaina26 Jan 26, 2025

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jan 26, 2025

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jan 27, 2025

Uh oh!

network-charles Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

Aaina26 Jan 30, 2025

Choose a reason for hiding this comment

Uh oh!

network-charles Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

Aaina26 commented Feb 11, 2025

Uh oh!

network-charles commented Feb 11, 2025

Uh oh!

k8s-ci-robot commented Feb 11, 2025

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Feb 16, 2025

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Jan 8, 2025 •

edited

Loading