Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd: add pull-etcd-operator-test-e2e job #34107

Merged

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Jan 8, 2025

Imports the e2e etcd operator tests. I copied the kind setup from

make WHAT="github.com/onsi/ginkgo/v2/ginkgo k8s.io/kubernetes/test/e2e/e2e.test k8s.io/kubernetes/cmd/kubectl" &&
curl -sSL https://kind.sigs.k8s.io/dl/latest/linux-amd64.tgz | tar xvfz - -C "${PATH%%:*}/" kind &&
kind build node-image --image node:latest &&
trap 'kind export logs "${ARTIFACTS}/kind"; kind delete cluster' EXIT &&
kind create cluster --retain --image node:latest &&
KUBERNETES_PROVIDER=local KUBECONFIG=${HOME}/.kube/config GINKGO_PARALLEL_NODES=1 E2E_REPORT_DIR=${ARTIFACTS} hack/ginkgo-e2e.sh -ginkgo.focus="\[sig-storage\].*\[Feature:Kind\].*\[Disruptive\]"
# docker-in-docker needs privileged mode
securityContext:
privileged: true

Part of etcd-io/etcd-operator#21.

/cc @jmhbnz

@k8s-ci-robot k8s-ci-robot requested a review from jmhbnz January 8, 2025 23:40
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 8, 2025
@ivanvc ivanvc force-pushed the import-etcd-operator-e2e-presubmit-job branch from 95ec75c to c6afcc9 Compare January 9, 2025 19:04
@ivanvc ivanvc force-pushed the import-etcd-operator-e2e-presubmit-job branch from c6afcc9 to 1fab606 Compare January 9, 2025 22:56
@ivanvc ivanvc requested a review from jmhbnz January 14, 2025 18:34
@ivanvc
Copy link
Member Author

ivanvc commented Jan 14, 2025

Gentle reminder, @jmhbnz :)

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @ivanvc

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit 42783ae into kubernetes:master Jan 15, 2025
6 of 7 checks passed
@k8s-ci-robot
Copy link
Contributor

@ivanvc: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-operator-presubmits.yaml using file config/jobs/etcd/etcd-operator-presubmits.yaml

In response to this:

Imports the e2e etcd operator tests. I copied the kind setup from

make WHAT="github.com/onsi/ginkgo/v2/ginkgo k8s.io/kubernetes/test/e2e/e2e.test k8s.io/kubernetes/cmd/kubectl" &&
curl -sSL https://kind.sigs.k8s.io/dl/latest/linux-amd64.tgz | tar xvfz - -C "${PATH%%:*}/" kind &&
kind build node-image --image node:latest &&
trap 'kind export logs "${ARTIFACTS}/kind"; kind delete cluster' EXIT &&
kind create cluster --retain --image node:latest &&
KUBERNETES_PROVIDER=local KUBECONFIG=${HOME}/.kube/config GINKGO_PARALLEL_NODES=1 E2E_REPORT_DIR=${ARTIFACTS} hack/ginkgo-e2e.sh -ginkgo.focus="\[sig-storage\].*\[Feature:Kind\].*\[Disruptive\]"
# docker-in-docker needs privileged mode
securityContext:
privileged: true

Part of etcd-io/etcd-operator#21.

/cc @jmhbnz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc ivanvc deleted the import-etcd-operator-e2e-presubmit-job branch January 15, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants