Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config/jobs: remove ci-kubernetes-build-deprecated #23002

Merged
merged 1 commit into from
Jul 23, 2021
Merged

config/jobs: remove ci-kubernetes-build-deprecated #23002

merged 1 commit into from
Jul 23, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 23, 2021 •
edited
Loading

Part of kubernetes/k8s.io#2318

v1.22 is the last release to write CI builds of kubernetes to gs://kubernetes-release-dev

As of v1.23, all CI builds should be written exclusively to gs://k8s-release-dev

Now that v1.22 jobs have been created, and the branch cut, I suspect this job is building v1.23. It should go away

/hold
To confirm v1.23 is getting built

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 23, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 23, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 23, 2021

Yeah, these shouldn't exist

$ gsutil ls gs://kubernetes-release-dev/ci | grep v1.23
gs://kubernetes-release-dev/ci/v1.23.0-alpha.0.1+fac3dd6914f95e/
gs://kubernetes-release-dev/ci/v1.23.0-alpha.0.11+9b84e473b28f0e/
gs://kubernetes-release-dev/ci/v1.23.0-alpha.0.13+603830b8a69454/
gs://kubernetes-release-dev/ci/v1.23.0-alpha.0.17+8ac0fcdb74f5bd/
gs://kubernetes-release-dev/ci/v1.23.0-alpha.0.19+f8ef5a94115951/
gs://kubernetes-release-dev/ci/v1.23.0-alpha.0.3+185d2e076f2290/
gs://kubernetes-release-dev/ci/v1.23.0-alpha.0.5+85a29212e03d83/
gs://kubernetes-release-dev/ci/v1.23.0-alpha.0.7+1a9ae3454993b2/
gs://kubernetes-release-dev/ci/v1.23.0-alpha.0.9+4818e5844eb67d/

@spiffxp
Copy link
Member Author

spiffxp commented Jul 23, 2021

/hold cancel
/assign @puerco @cpanato
FYI @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2021
@spiffxp spiffxp mentioned this pull request Jul 23, 2021
Closed
42 tasks
@ameukam
Copy link
Member

ameukam commented Jul 23, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2021
justaugustus
justaugustus approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye, bye, kubernetes_build scenario!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8fe6fa5 into kubernetes:master Jul 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 23, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubernetes-builds.yaml using file config/jobs/kubernetes/sig-release/kubernetes-builds.yaml

In response to this:

Part of kubernetes/k8s.io#2318

v1.22 is the last release to write CI builds of kubernetes to gs://kubernetes-release-dev

As of v1.23, all CI builds should be written exclusively to gs://k8s-release-dev

Now that v1.22 jobs have been created, and the branch cut, I suspect this job is building v1.23. It should go away

/hold
To confirm v1.23 is getting built

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Member Author

spiffxp commented Jul 23, 2021

Bye, bye, kubernetes_build scenario!

@justaugustus uhhh once the release-branch jobs age out, but we can certainly send the funeral pyre into the ocean now before we light it on fire in a year

@spiffxp spiffxp deleted the no-more-deprecated-builds branch July 23, 2021 18:04
@spiffxp
Copy link
Member Author

spiffxp commented Jul 23, 2021

I'm a little surprised I have the IAM privileges to do this, but I do, so cleaning up manually...

$ for build in $(gsutil ls gs://kubernetes-release-dev/ci | grep v1.23); do 
  gsutil -m rm -r $build
done

@spiffxp
Copy link
Member Author

spiffxp commented Jul 23, 2021

All gone

$ gsutil ls gs://kubernetes-release-dev/ci | grep v1.23
$

@justaugustus
Copy link
Member

Bye, bye, kubernetes_build scenario!

@justaugustus uhhh once the release-branch jobs age out, but we can certainly send the funeral pyre into the ocean now before we light it on fire in a year

Haha, yes. Just excited to see them no longer forked. It's been a journey 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus approved these changes

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@justaugustus justaugustus

@ameukam ameukam

@puerco puerco

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
6 participants
@spiffxp @ameukam @k8s-ci-robot @justaugustus @puerco @cpanato