Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant experimental overrides from jobs #17034

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Remove redundant experimental overrides from jobs #17034

merged 1 commit into from
Apr 1, 2020

Conversation

maniSbindra
Copy link
Contributor

This PR is to resolve the issue kubernetes/perf-tests#1036.
Now the variables can be overriden using the CL2_ prefix instead of the experimental overrides .
In kubernetes/perf-tests#1125 default values of all the variables referenced in experimental overrides other than ENABLE_NETWORKPOLICIES are set to true.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @maniSbindra. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 31, 2020
@maniSbindra
Copy link
Contributor Author

/assign @mm4tt

@maniSbindra maniSbindra force-pushed the remove-experimental-overrides branch from 2c1ce10 to e08140a Compare March 31, 2020 12:41
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 31, 2020
@mm4tt
Copy link
Contributor

mm4tt commented Mar 31, 2020

/assign @wojtek-t

@wojtek-t
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2020
@maniSbindra maniSbindra force-pushed the remove-experimental-overrides branch from e08140a to 574727e Compare April 1, 2020 10:41
@maniSbindra maniSbindra force-pushed the remove-experimental-overrides branch from 574727e to b14403b Compare April 1, 2020 10:46
@wojtek-t
Copy link
Member

wojtek-t commented Apr 1, 2020

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maniSbindra, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit 73284d4 into kubernetes:master Apr 1, 2020
@k8s-ci-robot
Copy link
Contributor

@maniSbindra: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key sig-scalability-experimental-periodic-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-experimental-periodic-jobs.yaml
  • key sig-scalability-periodic-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-periodic-jobs.yaml
  • key sig-scalability-presubmit-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-presubmit-jobs.yaml
  • key sig-scalability-release-blocking-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-release-blocking-jobs.yaml

In response to this:

This PR is to resolve the issue kubernetes/perf-tests#1036.
Now the variables can be overriden using the CL2_ prefix instead of the experimental overrides .
In kubernetes/perf-tests#1125 default values of all the variables referenced in experimental overrides other than ENABLE_NETWORKPOLICIES are set to true.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maniSbindra maniSbindra mentioned this pull request Apr 1, 2020
Merged
This was referenced Apr 3, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm4tt mm4tt mm4tt left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@hoegaarden hoegaarden Awaiting requested review from hoegaarden

@mborsz mborsz Awaiting requested review from mborsz

Assignees

@mm4tt mm4tt

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maniSbindra @k8s-ci-robot @mm4tt @wojtek-t