Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PVs for pre-submit kubemark jobs #16981

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Disable PVs for pre-submit kubemark jobs #16981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions config/jobs/kubernetes/sig-scalability/sig-scalability-presubmit-jobs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ presubmits:
- --test-cmd-args=cluster-loader2
- --test-cmd-args=--nodes=500
- --test-cmd-args=--provider=kubemark
- --env=CL2_ENABLE_PVS=false # TODO(https://github.com/kubernetes/perf-tests/issues/803): Fix me
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it might have been not clear. Now we have this env, let's delete the lines 225, 226, 419,420.

        # TODO(https://github.com/kubernetes/perf-tests/issues/803): Re-enable
        # - --test-cmd-args=--testoverrides=./testing/load/experimental/overrides/enable_pvs.yaml

They are redundant.

Also, coud you squash the commits into one? Thanks!

- --test-cmd-args=--report-dir=/workspace/_artifacts
- --test-cmd-args=--testconfig=testing/density/config.yaml
- --test-cmd-args=--testconfig=testing/load/config.yaml
Expand All @@ -221,8 +222,6 @@ presubmits:
- --test-cmd-args=--testoverrides=./testing/load/experimental/overrides/enable_configmaps.yaml
- --test-cmd-args=--testoverrides=./testing/load/experimental/overrides/enable_daemonsets.yaml
- --test-cmd-args=--testoverrides=./testing/load/experimental/overrides/enable_jobs.yaml
# TODO(https://github.com/kubernetes/perf-tests/issues/803): Re-enable
# - --test-cmd-args=--testoverrides=./testing/load/experimental/overrides/enable_pvs.yaml
- --test-cmd-args=--testoverrides=./testing/load/experimental/overrides/enable_secrets.yaml
- --test-cmd-args=--testoverrides=./testing/load/experimental/overrides/enable_statefulsets.yaml
- --test-cmd-args=--testoverrides=./testing/load/kubemark/500_nodes/override.yaml
Expand Down Expand Up @@ -406,6 +405,7 @@ presubmits:
- --test-cmd-args=--nodes=100
- --test-cmd-args=--prometheus-scrape-node-exporter
- --test-cmd-args=--provider=kubemark
- --env=CL2_ENABLE_PVS=false # TODO(https://github.com/kubernetes/perf-tests/issues/803): Fix me
- --test-cmd-args=--report-dir=/workspace/_artifacts
- --test-cmd-args=--testconfig=testing/density/config.yaml
- --test-cmd-args=--testconfig=testing/load/config.yaml
Expand All @@ -414,8 +414,6 @@ presubmits:
- --test-cmd-args=--testoverrides=./testing/load/experimental/overrides/enable_configmaps.yaml
- --test-cmd-args=--testoverrides=./testing/load/experimental/overrides/enable_daemonsets.yaml
- --test-cmd-args=--testoverrides=./testing/load/experimental/overrides/enable_jobs.yaml
# TODO(https://github.com/kubernetes/perf-tests/issues/803): Re-enable
#- --test-cmd-args=--testoverrides=./testing/load/experimental/overrides/enable_pvs.yaml
- --test-cmd-args=--testoverrides=./testing/load/experimental/overrides/enable_secrets.yaml
- --test-cmd-args=--testoverrides=./testing/load/experimental/overrides/enable_statefulsets.yaml
- --test-cmd-args=--testoverrides=./testing/experiments/enable_prometheus_api_responsiveness.yaml
Expand Down