-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental jobs for merged density and load #16186
Conversation
Job comes in two flavors with containerd and without (with docker).
/assign @wojtek-t |
- --scenario=kubernetes_e2e | ||
- -- | ||
- --check-leaked-resources | ||
# TODO(oxddr): remove once debugging is finished |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need it in our experimental one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't, but I wanted to keep it to original test as close to the perf-100 as possible.
That means this job config is almost the same as ci-kubernetes-e2e-gci-gce-scalability config.
- --test-cmd-args=--report-dir=/workspace/_artifacts | ||
- --test-cmd-args=--testconfig=testing/load/experimental-config.yaml | ||
- --test-cmd-args=--testoverrides=./testing/chaosmonkey/override.yaml | ||
- --test-cmd-args=--testoverrides=./testing/load/experimental/overrides/enable_configmaps.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need those? They are all enabled by default now (i.e. we don't use use those env vars IIRC).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They aren't enabled by default (even though they should be) and actually we have this litany of testoverrides in ~10+ places already (3 x kubemark, 2x gce, branch releases, etc.). I will file an issue to clean it up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- --scenario=kubernetes_e2e | ||
- -- | ||
- --check-leaked-resources | ||
# TODO(oxddr): remove once debugging is finished |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as above for this job.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mm4tt, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@mm4tt: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Job comes in two flavors with containerd and without (with docker).
Ref. kubernetes/perf-tests#1007
/hold
Wait for kubernetes/perf-tests#1008