Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump clusterloader deps #3088

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Bump clusterloader deps #3088

merged 3 commits into from
Jan 14, 2025

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Jan 8, 2025

This is a second attempt of #3050

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 8, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 8, 2025
@wojtek-t wojtek-t force-pushed the bump_clusterloader_deps_2 branch from dfec14e to 668422c Compare January 8, 2025 19:49
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2025
@wojtek-t wojtek-t force-pushed the bump_clusterloader_deps_2 branch from 5acb93b to 831ee15 Compare January 13, 2025 18:02
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2025
@wojtek-t
Copy link
Member Author

OK - using --experimental-gcp-snapshot-prometheus-disk=true" " now works with the third commit.
Cleaning this up and opening up for review.

@wojtek-t wojtek-t force-pushed the bump_clusterloader_deps_2 branch from 831ee15 to 9986ddf Compare January 14, 2025 07:24
@wojtek-t wojtek-t changed the title [WIP] Bump clusterloader deps Bump clusterloader deps Jan 14, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2025
@wojtek-t
Copy link
Member Author

/assign @tosi3k

@tosi3k
Copy link
Member

tosi3k commented Jan 14, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tosi3k, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 865d08a into kubernetes:master Jan 14, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mborsz mborsz Awaiting requested review from mborsz

@shyamjvs shyamjvs Awaiting requested review from shyamjvs

Assignees

@tosi3k tosi3k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wojtek-t @tosi3k @k8s-ci-robot