-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup clusterloader2 load testing experimental config file #1183
Cleanup clusterloader2 load testing experimental config file #1183
Conversation
Hi @maniSbindra. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Hmm - apparently I was wrong and this config is used (even though it wasn't modified for the last 7 months or so). |
Ohh I see now - it's merging load and density... @maniSbindra - sorry for that; apparently this is still used, so if you could actually revert this change and migrate actually clean up the unused vars the same way you did for other tests, it would be great! |
Thanks will make the required changes. |
759bba4
to
9445d60
Compare
Hi @wojtek-t I have pushed the requested changes. I have updated the PR and Title to reflect the changes |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maniSbindra, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As a part of #1125, default value of the variables
ENABLE_CONFIGMAPS, ENABLE_DAEMONSETS, ENABLE_JOBS, ENABLE_SECRETS, and ENABLE_STATEFULSETS are set to true, and these values are not overriden in any of the tests. The clusterloader2 load testing experimental-config.yaml file can now be be simplified as discussed in #1036 (comment)