Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup clusterloader2 load testing experimental config file #1183

Conversation

maniSbindra
Copy link
Contributor

@maniSbindra maniSbindra commented Apr 21, 2020

As a part of #1125, default value of the variables
ENABLE_CONFIGMAPS, ENABLE_DAEMONSETS, ENABLE_JOBS, ENABLE_SECRETS, and ENABLE_STATEFULSETS are set to true, and these values are not overriden in any of the tests. The clusterloader2 load testing experimental-config.yaml file can now be be simplified as discussed in #1036 (comment)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 21, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @maniSbindra. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 21, 2020
@k8s-ci-robot k8s-ci-robot requested review from oxddr and wojtek-t April 21, 2020 13:34
@wojtek-t
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2020
@wojtek-t
Copy link
Member

Hmm - apparently I was wrong and this config is used (even though it wasn't modified for the last 7 months or so).
@mm4tt - what is it used for now comparing the the regular load test?

@wojtek-t
Copy link
Member

Ohh I see now - it's merging load and density...

@maniSbindra - sorry for that; apparently this is still used, so if you could actually revert this change and migrate actually clean up the unused vars the same way you did for other tests, it would be great!

@maniSbindra
Copy link
Contributor Author

Thanks will make the required changes.

@maniSbindra maniSbindra changed the title Remove out of date clusterloader2 load testing experimental config file Cleanup clusterloader2 load testing experimental config file Apr 27, 2020
@maniSbindra maniSbindra force-pushed the remove-out-of-date-experimental-config-file branch from 759bba4 to 9445d60 Compare April 27, 2020 13:04
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 27, 2020
@maniSbindra
Copy link
Contributor Author

Hi @wojtek-t I have pushed the requested changes. I have updated the PR and Title to reflect the changes

@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maniSbindra, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4519151 into kubernetes:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants