Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick NodeKiller changes #1122

Merged
merged 4 commits into from
Mar 10, 2020
Merged

Cherry-pick NodeKiller changes #1122

merged 4 commits into from
Mar 10, 2020

Conversation

jprzychodzen
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 9, 2020
@k8s-ci-robot k8s-ci-robot requested review from mborsz and wojtek-t March 9, 2020 15:40
@jprzychodzen jprzychodzen force-pushed the release-1.16-nk-backport branch from ebe356d to 408cd2d Compare March 9, 2020 15:42
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 9, 2020
@jprzychodzen jprzychodzen force-pushed the release-1.16-nk-backport branch from 408cd2d to 03ef2b1 Compare March 9, 2020 15:47
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 9, 2020
@wojtek-t
Copy link
Member

wojtek-t commented Mar 9, 2020

@jprzychodzen - is this cherrypicking multiple different PRs? If so, those should be separate commits...

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2020
@jprzychodzen jprzychodzen force-pushed the release-1.16-nk-backport branch from 03ef2b1 to c97704f Compare March 10, 2020 08:43
@jprzychodzen
Copy link
Contributor Author

It is cherry-picking different commits. Removed the squash.
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2020
@mborsz
Copy link
Member

mborsz commented Mar 10, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jprzychodzen, mborsz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0188c4d into kubernetes:release-1.16 Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mborsz mborsz Awaiting requested review from mborsz

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@mborsz mborsz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jprzychodzen @wojtek-t @mborsz @k8s-ci-robot @mozhuli