-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update members of cloud-provider-gcp-maintainers #5327
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmamczur The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
remove sdmodi who left the GKE team. add mmamczur, member of the team that owns service controller part of cloupd-provider-gcp
/assign @bowei |
@@ -1351,8 +1351,8 @@ teams: | |||
- cici37 | |||
- jpbetz | |||
- jprzychodzen | |||
- mmamczur |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to split this into its own folder like what the other cloud providers did:
https://github.com/kubernetes/org/tree/main/config/kubernetes/provider-azure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a good way to set OWNERS files on this entire file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be great. Once you split off to a subdirectory, you wouldn't need org admins to approve PRs.
remove sdmodi who left the GKE team.
add mmamczur, member of the team that owns service controller part of cloupd-provider-gcp