Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update members of cloud-provider-gcp-maintainers #5327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmamczur
Copy link

@mmamczur mmamczur commented Jan 7, 2025

remove sdmodi who left the GKE team.
add mmamczur, member of the team that owns service controller part of cloupd-provider-gcp

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels Jan 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmamczur
Once this PR has been reviewed and has the lgtm label, please assign nikhita for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 7, 2025
remove sdmodi who left the GKE team.
add mmamczur, member of the team that owns service controller part of cloupd-provider-gcp
@mmamczur
Copy link
Author

mmamczur commented Jan 7, 2025

/assign @bowei

@@ -1351,8 +1351,8 @@ teams:
- cici37
- jpbetz
- jprzychodzen
- mmamczur
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to split this into its own folder like what the other cloud providers did:

https://github.com/kubernetes/org/tree/main/config/kubernetes/provider-azure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a good way to set OWNERS files on this entire file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be great. Once you split off to a subdirectory, you wouldn't need org admins to approve PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants