WIP: test merging functional_verified

[divysinghvi]

test pr
issue : #21915

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: divysinghvi
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @divysinghvi. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

now that we are adding "Runner" to the matrix, maybe we can remove "os" if it is not used anywhere ? or make them use runner.

[divysinghvi]

yes we can remove the os

[divysinghvi]

@medyagh right now didn't add the check for the ok-to-test also since i could not trigger that this was more of the test pr to check if it works , actually one thing that i was getting confused with is why here i am not seeing the functional test results am i missing something ?

[medyagh]

we would need to see if we can make that Only one of the Matrix items be required to have ok-to-test label and the test be as it is, can you see if thats possible?

feel free to make a Dummy Repo just to check that in a Dummy repo with a dummy workflow on your own repo

[divysinghvi]

Medhya i looked more into it thw core issue having is that GitHub Actions doesn't support conditional logic at the matrix definition level so we can't add a check in the include section , if that would have been possible it would be easier but it's not but we can add a check in the steps portion
- name: Check if arm64 job should run if: matrix.name == 'docker-docker-ubuntu-arm64' && github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'ok-to-test') run: | echo "Skipping arm64 job - 'ok-to-test' label not found on PR" exit 1
also please ignore the commits i am experimenting for the main pr i will close this on and create a fresh one once i figure this thing out thanks