[ci]: migrate kubernetes bootcamp image to prow #21904
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ComradeProgrammer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
@ComradeProgrammer: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -1,5 +1,4 @@ | |||
| .PHONY: integration-prow-kvm-docker-linux-x86-64 | |||
|
|
|||
| .PHONY: integration-prow-kvm-docker-linux-x86-64 integration-prow-docker-docker-linux-x86-64 push-kubernetes-bootcamp | |||
There was a problem hiding this comment.
how about add this new phony right before the target to match other ones. Instead of putting all .phonies in one place
| ./out/minitest --deployer boskos --tester kvm-docker-linux-amd64-integration --config hack/prow/kvm.json | ||
| ./out/minitest --deployer boskos --tester kvm-docker-linux-amd64-integration --config hack/prow/kvm.json | ||
|
|
||
| push-kubernetes-bootcamp: |
There was a problem hiding this comment.
how about naming it prow so all prow things have a prow in their name
push-prow-kubernetes-bootcamp:
| docker run --rm --privileged tonistiigi/binfmt:latest --install all | ||
| docker buildx create --name multiarch --bootstrap | ||
| docker buildx build --builder multiarch --push --platform linux/amd64,linux/arm64 \ | ||
| -t gcr.io/minikube/kubernetes-bootcamp:$(_GIT_TAG) -t gcr.io/minikube/kubernetes-bootcamp:latest deploy/image/kubernetes-bootcamp |
There was a problem hiding this comment.
do we have access to gcr.io/minikube in prow ?
3 participants
[ci]: migrate kubernetes bootcamp image to prow