Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump kubernetes packages to v0.32.1 #20363

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Bump kubernetes packages to v0.32.1 #20363

merged 1 commit into from
Feb 7, 2025

Conversation

prezha
Copy link
Contributor

@prezha prezha commented Feb 5, 2025 •
edited
Loading

Closes #20298

Resolves issues we saw in #20183 and that pr had to be reverted (#20229)

this pr bumps k8s.io/api, k8s.io/apimachinery and k8s.io/client-go packages to v0.32.1 and also fixes the tests failures accordingly in pkg/minikube/service/service_test.go and pkg/minikube/tunnel/loadbalancer_patcher_test.go

background: in v0.32, some mock test "helper" functions we used are un-exported, so we have to initialize manually - example for fake secrets: https://github.com/kubernetes/client-go/blob/v0.31.0/kubernetes/typed/core/v1/fake/fake_secret.go vs https://github.com/kubernetes/client-go/blob/v0.32.1/kubernetes/typed/core/v1/fake/fake_secret.go

after

service test

$ go test k8s.io/minikube/pkg/minikube/service -v

=== RUN   TestGetServiceListFromServicesByLabel
--- PASS: TestGetServiceListFromServicesByLabel (0.00s)
=== RUN   TestPrintURLsForService
=== RUN   TestPrintURLsForService/should_get_all_node_ports
=== PAUSE TestPrintURLsForService/should_get_all_node_ports
=== RUN   TestPrintURLsForService/should_get_all_node_ports_with_arbitrary_format
=== PAUSE TestPrintURLsForService/should_get_all_node_ports_with_arbitrary_format
=== RUN   TestPrintURLsForService/should_get_the_name_of_all_target_ports_with_arbitrary_format
=== PAUSE TestPrintURLsForService/should_get_the_name_of_all_target_ports_with_arbitrary_format
=== RUN   TestPrintURLsForService/empty_slice_for_no_node_ports
=== PAUSE TestPrintURLsForService/empty_slice_for_no_node_ports
=== RUN   TestPrintURLsForService/throw_error_without_template
=== PAUSE TestPrintURLsForService/throw_error_without_template
=== CONT  TestPrintURLsForService/should_get_all_node_ports
=== CONT  TestPrintURLsForService/empty_slice_for_no_node_ports
=== CONT  TestPrintURLsForService/throw_error_without_template
=== CONT  TestPrintURLsForService/should_get_the_name_of_all_target_ports_with_arbitrary_format
=== CONT  TestPrintURLsForService/should_get_all_node_ports_with_arbitrary_format
--- PASS: TestPrintURLsForService (0.00s)
    --- PASS: TestPrintURLsForService/empty_slice_for_no_node_ports (0.00s)
    --- PASS: TestPrintURLsForService/should_get_all_node_ports (0.00s)
    --- PASS: TestPrintURLsForService/throw_error_without_template (0.00s)
    --- PASS: TestPrintURLsForService/should_get_all_node_ports_with_arbitrary_format (0.00s)
    --- PASS: TestPrintURLsForService/should_get_the_name_of_all_target_ports_with_arbitrary_format (0.00s)
=== RUN   TestOptionallyHttpsFormattedUrlString
=== RUN   TestOptionallyHttpsFormattedUrlString/no_https_for_http_schemed_with_no_https_option
=== PAUSE TestOptionallyHttpsFormattedUrlString/no_https_for_http_schemed_with_no_https_option
=== RUN   TestOptionallyHttpsFormattedUrlString/no_https_for_non-http_schemed_with_no_https_option
=== PAUSE TestOptionallyHttpsFormattedUrlString/no_https_for_non-http_schemed_with_no_https_option
=== RUN   TestOptionallyHttpsFormattedUrlString/https_for_http_schemed_with_https_option
=== PAUSE TestOptionallyHttpsFormattedUrlString/https_for_http_schemed_with_https_option
=== RUN   TestOptionallyHttpsFormattedUrlString/no_https_for_non-http_schemed_with_https_option_and_http_substring
=== PAUSE TestOptionallyHttpsFormattedUrlString/no_https_for_non-http_schemed_with_https_option_and_http_substring
=== CONT  TestOptionallyHttpsFormattedUrlString/no_https_for_http_schemed_with_no_https_option
=== CONT  TestOptionallyHttpsFormattedUrlString/no_https_for_non-http_schemed_with_https_option_and_http_substring
=== CONT  TestOptionallyHttpsFormattedUrlString/https_for_http_schemed_with_https_option
=== CONT  TestOptionallyHttpsFormattedUrlString/no_https_for_non-http_schemed_with_no_https_option
--- PASS: TestOptionallyHttpsFormattedUrlString (0.00s)
    --- PASS: TestOptionallyHttpsFormattedUrlString/no_https_for_http_schemed_with_no_https_option (0.00s)
    --- PASS: TestOptionallyHttpsFormattedUrlString/no_https_for_non-http_schemed_with_https_option_and_http_substring (0.00s)
    --- PASS: TestOptionallyHttpsFormattedUrlString/https_for_http_schemed_with_https_option (0.00s)
    --- PASS: TestOptionallyHttpsFormattedUrlString/no_https_for_non-http_schemed_with_no_https_option (0.00s)
=== RUN   TestGetServiceURLs
=== RUN   TestGetServiceURLs/no_host
I0205 00:45:13.890993  975337 host.go:66] Checking if "minikube" exists ...
=== RUN   TestGetServiceURLs/correctly_return_serviceURLs
I0205 00:45:13.891235  975337 host.go:66] Checking if "minikube" exists ...
I0205 00:45:13.891241  975337 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0002500b0 DriverName: HostOptions:<nil> Name:minikube RawDriver:[]} - <nil>
I0205 00:45:13.891264  975337 driver_mock.go:47] MockDriver.GetIP
--- PASS: TestGetServiceURLs (0.00s)
    --- PASS: TestGetServiceURLs/no_host (0.00s)
    --- PASS: TestGetServiceURLs/correctly_return_serviceURLs (0.00s)
=== RUN   TestGetServiceURLsForService
=== RUN   TestGetServiceURLsForService/no_host
I0205 00:45:13.891318  975337 host.go:66] Checking if "minikube" exists ...
=== RUN   TestGetServiceURLsForService/correctly_return_serviceURLs
I0205 00:45:13.891335  975337 host.go:66] Checking if "minikube" exists ...
I0205 00:45:13.891338  975337 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc000829290 DriverName: HostOptions:<nil> Name:minikube RawDriver:[]} - <nil>
I0205 00:45:13.891348  975337 driver_mock.go:47] MockDriver.GetIP
=== RUN   TestGetServiceURLsForService/correctly_return_empty_serviceURLs
I0205 00:45:13.891367  975337 host.go:66] Checking if "minikube" exists ...
I0205 00:45:13.891390  975337 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc000829290 DriverName: HostOptions:<nil> Name:minikube RawDriver:[]} - <nil>
I0205 00:45:13.891399  975337 driver_mock.go:47] MockDriver.GetIP
--- PASS: TestGetServiceURLsForService (0.00s)
    --- PASS: TestGetServiceURLsForService/no_host (0.00s)
    --- PASS: TestGetServiceURLsForService/correctly_return_serviceURLs (0.00s)
    --- PASS: TestGetServiceURLsForService/correctly_return_empty_serviceURLs (0.00s)
=== RUN   TestGetCoreClient
=== RUN   TestGetCoreClient/ok
=== RUN   TestGetCoreClient/empty_config
=== RUN   TestGetCoreClient/broken_config
--- PASS: TestGetCoreClient (0.00s)
    --- PASS: TestGetCoreClient/ok (0.00s)
    --- PASS: TestGetCoreClient/empty_config (0.00s)
    --- PASS: TestGetCoreClient/broken_config (0.00s)
=== RUN   TestPrintServiceList
--- PASS: TestPrintServiceList (0.00s)
=== RUN   TestGetServiceListByLabel
=== RUN   TestGetServiceListByLabel/ok
=== RUN   TestGetServiceListByLabel/failed_get_client
=== RUN   TestGetServiceListByLabel/no_matches
--- PASS: TestGetServiceListByLabel (0.00s)
    --- PASS: TestGetServiceListByLabel/ok (0.00s)
    --- PASS: TestGetServiceListByLabel/failed_get_client (0.00s)
    --- PASS: TestGetServiceListByLabel/no_matches (0.00s)
=== RUN   TestCheckService
=== RUN   TestCheckService/ok
I0205 00:45:13.892292  975337 service.go:214] Found service: &Service{ObjectMeta:{mock-dashboard  default    0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[mock:mock] map[] [] [] []},Spec:ServiceSpec{Ports:[]ServicePort{ServicePort{Name:port1,Protocol:,Port:11111,TargetPort:{0 11111 },NodePort:1111,AppProtocol:nil,},ServicePort{Name:port2,Protocol:,Port:22222,TargetPort:{0 22222 },NodePort:2222,AppProtocol:nil,},},Selector:map[string]string{},ClusterIP:,Type:,ExternalIPs:[],SessionAffinity:,LoadBalancerIP:,LoadBalancerSourceRanges:[],ExternalName:,ExternalTrafficPolicy:,HealthCheckNodePort:0,PublishNotReadyAddresses:false,SessionAffinityConfig:nil,IPFamilyPolicy:nil,ClusterIPs:[],IPFamilies:[],AllocateLoadBalancerNodePorts:nil,LoadBalancerClass:nil,InternalTrafficPolicy:nil,TrafficDistribution:nil,},Status:ServiceStatus{LoadBalancer:LoadBalancerStatus{Ingress:[]LoadBalancerIngress{},},Conditions:[]Condition{},},}
=== RUN   TestCheckService/failed_get_client
=== RUN   TestCheckService/svc_no_ports
--- PASS: TestCheckService (0.00s)
    --- PASS: TestCheckService/ok (0.00s)
    --- PASS: TestCheckService/failed_get_client (0.00s)
    --- PASS: TestCheckService/svc_no_ports (0.00s)
=== RUN   TestDeleteSecret
=== RUN   TestDeleteSecret/ok
=== RUN   TestDeleteSecret/failed_get_client
--- PASS: TestDeleteSecret (0.00s)
    --- PASS: TestDeleteSecret/ok (0.00s)
    --- PASS: TestDeleteSecret/failed_get_client (0.00s)
=== RUN   TestCreateSecret
=== RUN   TestCreateSecret/ok
=== RUN   TestCreateSecret/failed_get_client
--- PASS: TestCreateSecret (0.00s)
    --- PASS: TestCreateSecret/ok (0.00s)
    --- PASS: TestCreateSecret/failed_get_client (0.00s)
=== RUN   TestWaitAndMaybeOpenService
=== RUN   TestWaitAndMaybeOpenService/correctly_return_serviceURLs,_https,_no_url_mode
I0205 00:45:13.892519  975337 service.go:214] Found service: &Service{ObjectMeta:{mock-dashboard  default    0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[mock:mock] map[] [] [] []},Spec:ServiceSpec{Ports:[]ServicePort{ServicePort{Name:port1,Protocol:,Port:11111,TargetPort:{0 11111 },NodePort:1111,AppProtocol:nil,},ServicePort{Name:port2,Protocol:,Port:22222,TargetPort:{0 22222 },NodePort:2222,AppProtocol:nil,},},Selector:map[string]string{},ClusterIP:,Type:,ExternalIPs:[],SessionAffinity:,LoadBalancerIP:,LoadBalancerSourceRanges:[],ExternalName:,ExternalTrafficPolicy:,HealthCheckNodePort:0,PublishNotReadyAddresses:false,SessionAffinityConfig:nil,IPFamilyPolicy:nil,ClusterIPs:[],IPFamilies:[],AllocateLoadBalancerNodePorts:nil,LoadBalancerClass:nil,InternalTrafficPolicy:nil,TrafficDistribution:nil,},Status:ServiceStatus{LoadBalancer:LoadBalancerStatus{Ingress:[]LoadBalancerIngress{},},Conditions:[]Condition{},},}
I0205 00:45:13.892554  975337 host.go:66] Checking if "minikube" exists ...
I0205 00:45:13.892558  975337 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0008294a0 DriverName: HostOptions:<nil> Name:minikube RawDriver:[]} - <nil>
I0205 00:45:13.892584  975337 driver_mock.go:47] MockDriver.GetIP
|-----------|----------------|-------------|-----------------------|
| NAMESPACE |      NAME      | TARGET PORT |          URL          |
|-----------|----------------|-------------|-----------------------|
| default   | mock-dashboard | port1/11111 | http://127.0.0.1:1111 |
|           |                | port2/22222 | http://127.0.0.1:2222 |
|-----------|----------------|-------------|-----------------------|
=== RUN   TestWaitAndMaybeOpenService/correctly_return_serviceURLs,_no_https,_no_url_mode
I0205 00:45:13.892776  975337 service.go:214] Found service: &Service{ObjectMeta:{mock-dashboard  default    0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[mock:mock] map[] [] [] []},Spec:ServiceSpec{Ports:[]ServicePort{ServicePort{Name:port1,Protocol:,Port:11111,TargetPort:{0 11111 },NodePort:1111,AppProtocol:nil,},ServicePort{Name:port2,Protocol:,Port:22222,TargetPort:{0 22222 },NodePort:2222,AppProtocol:nil,},},Selector:map[string]string{},ClusterIP:,Type:,ExternalIPs:[],SessionAffinity:,LoadBalancerIP:,LoadBalancerSourceRanges:[],ExternalName:,ExternalTrafficPolicy:,HealthCheckNodePort:0,PublishNotReadyAddresses:false,SessionAffinityConfig:nil,IPFamilyPolicy:nil,ClusterIPs:[],IPFamilies:[],AllocateLoadBalancerNodePorts:nil,LoadBalancerClass:nil,InternalTrafficPolicy:nil,TrafficDistribution:nil,},Status:ServiceStatus{LoadBalancer:LoadBalancerStatus{Ingress:[]LoadBalancerIngress{},},Conditions:[]Condition{},},}
I0205 00:45:13.892803  975337 host.go:66] Checking if "minikube" exists ...
I0205 00:45:13.892806  975337 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0008294a0 DriverName: HostOptions:<nil> Name:minikube RawDriver:[]} - <nil>
I0205 00:45:13.892810  975337 driver_mock.go:47] MockDriver.GetIP
|-----------|----------------|-------------|-----------------------|
| NAMESPACE |      NAME      | TARGET PORT |          URL          |
|-----------|----------------|-------------|-----------------------|
| default   | mock-dashboard | port1/11111 | http://127.0.0.1:1111 |
|           |                | port2/22222 | http://127.0.0.1:2222 |
|-----------|----------------|-------------|-----------------------|
=== RUN   TestWaitAndMaybeOpenService/correctly_return_serviceURLs,_no_https,_url_mode
I0205 00:45:13.892946  975337 service.go:214] Found service: &Service{ObjectMeta:{mock-dashboard  default    0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[mock:mock] map[] [] [] []},Spec:ServiceSpec{Ports:[]ServicePort{ServicePort{Name:port1,Protocol:,Port:11111,TargetPort:{0 11111 },NodePort:1111,AppProtocol:nil,},ServicePort{Name:port2,Protocol:,Port:22222,TargetPort:{0 22222 },NodePort:2222,AppProtocol:nil,},},Selector:map[string]string{},ClusterIP:,Type:,ExternalIPs:[],SessionAffinity:,LoadBalancerIP:,LoadBalancerSourceRanges:[],ExternalName:,ExternalTrafficPolicy:,HealthCheckNodePort:0,PublishNotReadyAddresses:false,SessionAffinityConfig:nil,IPFamilyPolicy:nil,ClusterIPs:[],IPFamilies:[],AllocateLoadBalancerNodePorts:nil,LoadBalancerClass:nil,InternalTrafficPolicy:nil,TrafficDistribution:nil,},Status:ServiceStatus{LoadBalancer:LoadBalancerStatus{Ingress:[]LoadBalancerIngress{},},Conditions:[]Condition{},},}
I0205 00:45:13.892970  975337 host.go:66] Checking if "minikube" exists ...
I0205 00:45:13.892973  975337 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0008294a0 DriverName: HostOptions:<nil> Name:minikube RawDriver:[]} - <nil>
I0205 00:45:13.892977  975337 driver_mock.go:47] MockDriver.GetIP
=== RUN   TestWaitAndMaybeOpenService/correctly_return_serviceURLs,_https,_url_mode
I0205 00:45:13.893001  975337 service.go:214] Found service: &Service{ObjectMeta:{mock-dashboard  default    0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[mock:mock] map[] [] [] []},Spec:ServiceSpec{Ports:[]ServicePort{ServicePort{Name:port1,Protocol:,Port:11111,TargetPort:{0 11111 },NodePort:1111,AppProtocol:nil,},ServicePort{Name:port2,Protocol:,Port:22222,TargetPort:{0 22222 },NodePort:2222,AppProtocol:nil,},},Selector:map[string]string{},ClusterIP:,Type:,ExternalIPs:[],SessionAffinity:,LoadBalancerIP:,LoadBalancerSourceRanges:[],ExternalName:,ExternalTrafficPolicy:,HealthCheckNodePort:0,PublishNotReadyAddresses:false,SessionAffinityConfig:nil,IPFamilyPolicy:nil,ClusterIPs:[],IPFamilies:[],AllocateLoadBalancerNodePorts:nil,LoadBalancerClass:nil,InternalTrafficPolicy:nil,TrafficDistribution:nil,},Status:ServiceStatus{LoadBalancer:LoadBalancerStatus{Ingress:[]LoadBalancerIngress{},},Conditions:[]Condition{},},}
I0205 00:45:13.893024  975337 host.go:66] Checking if "minikube" exists ...
I0205 00:45:13.893027  975337 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0008294a0 DriverName: HostOptions:<nil> Name:minikube RawDriver:[]} - <nil>
I0205 00:45:13.893031  975337 driver_mock.go:47] MockDriver.GetIP
=== RUN   TestWaitAndMaybeOpenService/correctly_return_serviceURLs,_http,_url_mode
I0205 00:45:13.893049  975337 service.go:214] Found service: &Service{ObjectMeta:{mock-dashboard  default    0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[mock:mock] map[] [] [] []},Spec:ServiceSpec{Ports:[]ServicePort{ServicePort{Name:port1,Protocol:,Port:11111,TargetPort:{0 11111 },NodePort:1111,AppProtocol:nil,},ServicePort{Name:port2,Protocol:,Port:22222,TargetPort:{0 22222 },NodePort:2222,AppProtocol:nil,},},Selector:map[string]string{},ClusterIP:,Type:,ExternalIPs:[],SessionAffinity:,LoadBalancerIP:,LoadBalancerSourceRanges:[],ExternalName:,ExternalTrafficPolicy:,HealthCheckNodePort:0,PublishNotReadyAddresses:false,SessionAffinityConfig:nil,IPFamilyPolicy:nil,ClusterIPs:[],IPFamilies:[],AllocateLoadBalancerNodePorts:nil,LoadBalancerClass:nil,InternalTrafficPolicy:nil,TrafficDistribution:nil,},Status:ServiceStatus{LoadBalancer:LoadBalancerStatus{Ingress:[]LoadBalancerIngress{},},Conditions:[]Condition{},},}
I0205 00:45:13.893071  975337 host.go:66] Checking if "minikube" exists ...
I0205 00:45:13.893074  975337 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0008294a0 DriverName: HostOptions:<nil> Name:minikube RawDriver:[]} - <nil>
I0205 00:45:13.893077  975337 driver_mock.go:47] MockDriver.GetIP
=== RUN   TestWaitAndMaybeOpenService/correctly_return_empty_serviceURLs
I0205 00:45:13.893133  975337 retry.go:31] will retry after 1.169222739s: default:mock-dashboard-no-ports has no ports
I0205 00:45:15.062591  975337 retry.go:31] will retry after 1.960306877s: default:mock-dashboard-no-ports has no ports
=== RUN   TestWaitAndMaybeOpenService/correctly_return_serviceURLs_for_a_delayed_service
I0205 00:45:17.023303  975337 service.go:214] Found service: &Service{ObjectMeta:{mock-dashboard-delayed  default    0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[mock:mock] map[] [] [] []},Spec:ServiceSpec{Ports:[]ServicePort{ServicePort{Name:port1,Protocol:,Port:11111,TargetPort:{0 11111 },NodePort:1111,AppProtocol:nil,},},Selector:map[string]string{},ClusterIP:,Type:,ExternalIPs:[],SessionAffinity:,LoadBalancerIP:,LoadBalancerSourceRanges:[],ExternalName:,ExternalTrafficPolicy:,HealthCheckNodePort:0,PublishNotReadyAddresses:false,SessionAffinityConfig:nil,IPFamilyPolicy:nil,ClusterIPs:[],IPFamilies:[],AllocateLoadBalancerNodePorts:nil,LoadBalancerClass:nil,InternalTrafficPolicy:nil,TrafficDistribution:nil,},Status:ServiceStatus{LoadBalancer:LoadBalancerStatus{Ingress:[]LoadBalancerIngress{},},Conditions:[]Condition{},},}
I0205 00:45:17.023431  975337 host.go:66] Checking if "minikube" exists ...
I0205 00:45:17.023437  975337 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0008294a0 DriverName: HostOptions:<nil> Name:minikube RawDriver:[]} - <nil>
I0205 00:45:17.023461  975337 driver_mock.go:47] MockDriver.GetIP
|-----------|------------------------|-------------|-----------------------|
| NAMESPACE |          NAME          | TARGET PORT |          URL          |
|-----------|------------------------|-------------|-----------------------|
| default   | mock-dashboard-delayed | port1/11111 | http://127.0.0.1:1111 |
|-----------|------------------------|-------------|-----------------------|
--- PASS: TestWaitAndMaybeOpenService (3.13s)
    --- PASS: TestWaitAndMaybeOpenService/correctly_return_serviceURLs,_https,_no_url_mode (0.00s)
    --- PASS: TestWaitAndMaybeOpenService/correctly_return_serviceURLs,_no_https,_no_url_mode (0.00s)
    --- PASS: TestWaitAndMaybeOpenService/correctly_return_serviceURLs,_no_https,_url_mode (0.00s)
    --- PASS: TestWaitAndMaybeOpenService/correctly_return_serviceURLs,_https,_url_mode (0.00s)
    --- PASS: TestWaitAndMaybeOpenService/correctly_return_serviceURLs,_http,_url_mode (0.00s)
    --- PASS: TestWaitAndMaybeOpenService/correctly_return_empty_serviceURLs (3.13s)
    --- PASS: TestWaitAndMaybeOpenService/correctly_return_serviceURLs_for_a_delayed_service (0.00s)
=== RUN   TestWaitAndMaybeOpenServiceForNotDefaultNamspace
=== RUN   TestWaitAndMaybeOpenServiceForNotDefaultNamspace/correctly_return_empty_serviceURLs
I0205 00:45:17.023809  975337 retry.go:31] will retry after 864.025726ms: default:non-namespace-dashboard-no-ports has no ports
--- PASS: TestWaitAndMaybeOpenServiceForNotDefaultNamspace (0.87s)
    --- PASS: TestWaitAndMaybeOpenServiceForNotDefaultNamspace/correctly_return_empty_serviceURLs (0.87s)
PASS
ok  	k8s.io/minikube/pkg/minikube/service	4.021s
tunnel test

$ go test k8s.io/minikube/pkg/minikube/tunnel -v

=== RUN   TestAPIError
I0205 00:45:28.216244  976289 host.go:66] Checking if "nonexistentmachine" exists ...
--- PASS: TestAPIError (0.00s)
=== RUN   TestMinikubeCheckReturnsHostInformation
I0205 00:45:28.216361  976289 host.go:66] Checking if "testmachine" exists ...
I0205 00:45:28.216364  976289 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0004c9130 DriverName: HostOptions:<nil> Name: RawDriver:[]} - <nil>
I0205 00:45:28.216417  976289 driver_mock.go:47] MockDriver.GetState called from /home/prezha/dev/Kubernetes/minikube/github.com/prezha/minikube/pkg/minikube/tunnel/cluster_inspector.go#62: returning "Running"
I0205 00:45:28.216421  976289 driver_mock.go:47] MockDriver.GetIP
--- PASS: TestMinikubeCheckReturnsHostInformation (0.00s)
=== RUN   TestUnparseableCIDR
I0205 00:45:28.216462  976289 driver_mock.go:47] MockDriver.GetIP
--- PASS: TestUnparseableCIDR (0.00s)
=== RUN   TestRouteIPDetection
I0205 00:45:28.216480  976289 driver_mock.go:47] MockDriver.GetIP
--- PASS: TestRouteIPDetection (0.00s)
=== RUN   TestEmptyListOfServicesDoesNothing
--- PASS: TestEmptyListOfServicesDoesNothing (0.00s)
=== RUN   TestServicesWithNoLoadbalancerType
--- PASS: TestServicesWithNoLoadbalancerType (0.00s)
=== RUN   TestServicesWithLoadbalancerType
I0205 00:45:28.216571  976289 loadbalancer_patcher.go:80] svc1-up-to-date is type LoadBalancer.
I0205 00:45:28.216574  976289 loadbalancer_patcher.go:80] svc2-out-of-date is type LoadBalancer.
I0205 00:45:28.216581  976289 loadbalancer_patcher.go:122] Patched svc2-out-of-date with IP 10.96.0.4
I0205 00:45:28.216583  976289 loadbalancer_patcher.go:80] svc3-empty-ingress is type LoadBalancer.
I0205 00:45:28.216586  976289 loadbalancer_patcher.go:122] Patched svc3-empty-ingress with IP 10.96.0.2
--- PASS: TestServicesWithLoadbalancerType (0.00s)
=== RUN   TestCleanupPatchedIPs
I0205 00:45:28.216631  976289 loadbalancer_patcher.go:80] svc1-up-to-date is type LoadBalancer.
I0205 00:45:28.216640  976289 loadbalancer_patcher.go:145] Removed load balancer ingress from svc1-up-to-date.
I0205 00:45:28.216643  976289 loadbalancer_patcher.go:80] svc2-out-of-date is type LoadBalancer.
I0205 00:45:28.216645  976289 loadbalancer_patcher.go:145] Removed load balancer ingress from svc2-out-of-date.
I0205 00:45:28.216647  976289 loadbalancer_patcher.go:80] svc3-empty-ingress is type LoadBalancer.
--- PASS: TestCleanupPatchedIPs (0.00s)
=== RUN   TestPersistentRegistryWithNoKey
--- PASS: TestPersistentRegistryWithNoKey (0.00s)
=== RUN   TestPersistentRegistryNullableMetadata
--- PASS: TestPersistentRegistryNullableMetadata (0.00s)
=== RUN   TestListOnEmptyRegistry
--- PASS: TestListOnEmptyRegistry (0.00s)
=== RUN   TestRemoveOnEmptyRegistry
--- PASS: TestRemoveOnEmptyRegistry (0.00s)
=== RUN   TestRegisterOnEmptyRegistry
--- PASS: TestRegisterOnEmptyRegistry (0.00s)
=== RUN   TestRemoveOnNonExistentTunnel
--- PASS: TestRemoveOnNonExistentTunnel (0.00s)
=== RUN   TestListAfterRegister
--- PASS: TestListAfterRegister (0.00s)
=== RUN   TestRegisterRemoveList
--- PASS: TestRegisterRemoveList (0.00s)
=== RUN   TestDuplicateRouteError
--- PASS: TestDuplicateRouteError (0.00s)
=== RUN   TestTunnelTakeoverFromNonRunningProcess
--- PASS: TestTunnelTakeoverFromNonRunningProcess (0.00s)
=== RUN   TestReporter
=== RUN   TestReporter/simple
=== RUN   TestReporter/errors
--- PASS: TestReporter (0.00s)
    --- PASS: TestReporter/simple (0.00s)
    --- PASS: TestReporter/errors (0.00s)
=== RUN   TestRoutingTable
=== RUN   TestRoutingTable/doesn't_exist,_no_complication
=== RUN   TestRoutingTable/doesn't_exist,_and_has_overlap_and_a_conflict
=== RUN   TestRoutingTable/exists,_and_has_overlap_and_no_conflict
--- PASS: TestRoutingTable (0.00s)
    --- PASS: TestRoutingTable/doesn't_exist,_no_complication (0.00s)
    --- PASS: TestRoutingTable/doesn't_exist,_and_has_overlap_and_a_conflict (0.00s)
    --- PASS: TestRoutingTable/exists,_and_has_overlap_and_no_conflict (0.00s)
=== RUN   TestTunnelManagerEventHandling
=== RUN   TestTunnelManagerEventHandling/tunnel_quits_on_stopped_minikube
I0205 00:45:28.218010  976289 tunnel_manager_test.go:45] waiting for tunnel to be ready.
I0205 00:45:28.218016  976289 tunnel_manager_test.go:47] check!
I0205 00:45:28.218018  976289 tunnel_manager_test.go:49] check done.
I0205 00:45:28.218028  976289 tunnel_manager.go:116] minikube status: Stopped, cleaning up and quitting...
I0205 00:45:28.218035  976289 tunnel_manager_test.go:52] it's done, yay!
=== RUN   TestTunnelManagerEventHandling/tunnel_quits_on_ctrlc_before_doing_a_check
=== RUN   TestTunnelManagerEventHandling/tunnel_always_quits_when_ctrl_c_is_pressed
--- PASS: TestTunnelManagerEventHandling (0.36s)
    --- PASS: TestTunnelManagerEventHandling/tunnel_quits_on_stopped_minikube (0.00s)
    --- PASS: TestTunnelManagerEventHandling/tunnel_quits_on_ctrlc_before_doing_a_check (0.00s)
    --- PASS: TestTunnelManagerEventHandling/tunnel_always_quits_when_ctrl_c_is_pressed (0.36s)
=== RUN   TestTunnelManagerDelayAndContext
I0205 00:45:28.575263  976289 tunnel_manager.go:71] Setting up tunnel...
I0205 00:45:28.575272  976289 tunnel_manager.go:81] Started minikube tunnel.
--- PASS: TestTunnelManagerDelayAndContext (1.10s)
=== RUN   TestTunnelManagerCleanup
I0205 00:45:29.675944  976289 tunnel_manager.go:138] ID { Route: 5.0.0.0/9 -> 1.2.3.4, machineName: minikube, Pid: 976289 } is running: true
I0205 00:45:29.675955  976289 tunnel_manager.go:138] ID { Route: 200.0.0.0/9 -> 100.2.3.4, machineName: minikube, Pid: 976289 } is running: true
I0205 00:45:29.675979  976289 tunnel_manager.go:138] ID { Route: 10.0.0.0/9 -> 200.2.3.4, machineName: minikube, Pid: 12341234 } is running: false
I0205 00:45:29.676056  976289 tunnel_manager.go:138] ID { Route: 20.0.0.0/9 -> 250.2.3.4, machineName: minikube, Pid: 12341234 } is running: false
--- PASS: TestTunnelManagerCleanup (0.00s)
=== RUN   TestTunnel
=== RUN   TestTunnel/simple_stopped
I0205 00:45:29.676240  976289 host.go:66] Checking if "testmachine" exists ...
I0205 00:45:29.676257  976289 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0004c9130 DriverName: HostOptions:<nil> Name: RawDriver:[]} - <nil>
I0205 00:45:29.676283  976289 driver_mock.go:47] MockDriver.GetState called from /home/prezha/dev/Kubernetes/minikube/github.com/prezha/minikube/pkg/minikube/tunnel/cluster_inspector.go#62: returning "Stopped"
I0205 00:45:29.676286  976289 driver_mock.go:47] MockDriver.GetIP
I0205 00:45:29.676314  976289 host.go:66] Checking if "testmachine" exists ...
I0205 00:45:29.676316  976289 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0004c9130 DriverName: HostOptions:<nil> Name: RawDriver:[]} - <nil>
I0205 00:45:29.676321  976289 driver_mock.go:47] MockDriver.GetState called from /home/prezha/dev/Kubernetes/minikube/github.com/prezha/minikube/pkg/minikube/tunnel/tunnel.go#119: returning "Stopped"
=== RUN   TestTunnel/tunnel_cleanup_(ctrl+c_before_check)
I0205 00:45:29.676386  976289 host.go:66] Checking if "testmachine" exists ...
I0205 00:45:29.676389  976289 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0004c91e0 DriverName: HostOptions:<nil> Name: RawDriver:[]} - <nil>
I0205 00:45:29.676407  976289 driver_mock.go:47] MockDriver.GetState called from /home/prezha/dev/Kubernetes/minikube/github.com/prezha/minikube/pkg/minikube/tunnel/cluster_inspector.go#62: returning "Running"
I0205 00:45:29.676410  976289 driver_mock.go:47] MockDriver.GetIP
=== RUN   TestTunnel/tunnel_create_Route
I0205 00:45:29.676511  976289 host.go:66] Checking if "testmachine" exists ...
I0205 00:45:29.676534  976289 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0004c9290 DriverName: HostOptions:<nil> Name: RawDriver:[]} - <nil>
I0205 00:45:29.676539  976289 driver_mock.go:47] MockDriver.GetState called from /home/prezha/dev/Kubernetes/minikube/github.com/prezha/minikube/pkg/minikube/tunnel/cluster_inspector.go#62: returning "Running"
I0205 00:45:29.676542  976289 driver_mock.go:47] MockDriver.GetIP
I0205 00:45:29.676549  976289 host.go:66] Checking if "testmachine" exists ...
I0205 00:45:29.676566  976289 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0004c9290 DriverName: HostOptions:<nil> Name: RawDriver:[]} - <nil>
I0205 00:45:29.676570  976289 driver_mock.go:47] MockDriver.GetState called from /home/prezha/dev/Kubernetes/minikube/github.com/prezha/minikube/pkg/minikube/tunnel/tunnel.go#119: returning "Running"
=== RUN   TestTunnel/tunnel_cleanup_error_after_1_successful_addRoute
I0205 00:45:29.676717  976289 host.go:66] Checking if "testmachine" exists ...
I0205 00:45:29.676720  976289 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0004c93f0 DriverName: HostOptions:<nil> Name: RawDriver:[]} - <nil>
I0205 00:45:29.676727  976289 driver_mock.go:47] MockDriver.GetState called from /home/prezha/dev/Kubernetes/minikube/github.com/prezha/minikube/pkg/minikube/tunnel/cluster_inspector.go#62: returning "Running"
I0205 00:45:29.676730  976289 driver_mock.go:47] MockDriver.GetIP
I0205 00:45:29.676754  976289 host.go:66] Checking if "testmachine" exists ...
I0205 00:45:29.676757  976289 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0004c93f0 DriverName: HostOptions:<nil> Name: RawDriver:[]} - <nil>
I0205 00:45:29.676776  976289 driver_mock.go:47] MockDriver.GetState called from /home/prezha/dev/Kubernetes/minikube/github.com/prezha/minikube/pkg/minikube/tunnel/tunnel.go#119: returning "Running"
=== RUN   TestTunnel/tunnel_cleanup
I0205 00:45:29.676916  976289 host.go:66] Checking if "testmachine" exists ...
I0205 00:45:29.676920  976289 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0004c9550 DriverName: HostOptions:<nil> Name: RawDriver:[]} - <nil>
I0205 00:45:29.676925  976289 driver_mock.go:47] MockDriver.GetState called from /home/prezha/dev/Kubernetes/minikube/github.com/prezha/minikube/pkg/minikube/tunnel/cluster_inspector.go#62: returning "Running"
I0205 00:45:29.676928  976289 driver_mock.go:47] MockDriver.GetIP
I0205 00:45:29.676957  976289 host.go:66] Checking if "testmachine" exists ...
I0205 00:45:29.676960  976289 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0004c9550 DriverName: HostOptions:<nil> Name: RawDriver:[]} - <nil>
I0205 00:45:29.676964  976289 driver_mock.go:47] MockDriver.GetState called from /home/prezha/dev/Kubernetes/minikube/github.com/prezha/minikube/pkg/minikube/tunnel/tunnel.go#119: returning "Running"
=== RUN   TestTunnel/race_condition:_other_tunnel_registers_while_in_between_routing_and_registration
I0205 00:45:29.677061  976289 host.go:66] Checking if "testmachine" exists ...
I0205 00:45:29.677064  976289 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0004c9600 DriverName: HostOptions:<nil> Name: RawDriver:[]} - <nil>
I0205 00:45:29.677069  976289 driver_mock.go:47] MockDriver.GetState called from /home/prezha/dev/Kubernetes/minikube/github.com/prezha/minikube/pkg/minikube/tunnel/cluster_inspector.go#62: returning "Running"
I0205 00:45:29.677071  976289 driver_mock.go:47] MockDriver.GetIP
I0205 00:45:29.677127  976289 host.go:66] Checking if "testmachine" exists ...
I0205 00:45:29.677131  976289 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0004c9600 DriverName: HostOptions:<nil> Name: RawDriver:[]} - <nil>
I0205 00:45:29.677151  976289 driver_mock.go:47] MockDriver.GetState called from /home/prezha/dev/Kubernetes/minikube/github.com/prezha/minikube/pkg/minikube/tunnel/tunnel.go#119: returning "Running"
E0205 00:45:29.677167  976289 tunnel.go:148] failed to register tunnel: there is already a running tunnel for this machine: ID { Route: 0.0.0.0/5 -> 1.2.3.4, machineName: testmachine, Pid: 1235 }
=== RUN   TestTunnel/race_condition:_other_tunnel_registers_and_creates_the_same_route_first
I0205 00:45:29.677231  976289 host.go:66] Checking if "testmachine" exists ...
I0205 00:45:29.677234  976289 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0004c96b0 DriverName: HostOptions:<nil> Name: RawDriver:[]} - <nil>
I0205 00:45:29.677240  976289 driver_mock.go:47] MockDriver.GetState called from /home/prezha/dev/Kubernetes/minikube/github.com/prezha/minikube/pkg/minikube/tunnel/cluster_inspector.go#62: returning "Running"
I0205 00:45:29.677242  976289 driver_mock.go:47] MockDriver.GetIP
I0205 00:45:29.677263  976289 host.go:66] Checking if "testmachine" exists ...
I0205 00:45:29.677265  976289 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0004c96b0 DriverName: HostOptions:<nil> Name: RawDriver:[]} - <nil>
I0205 00:45:29.677270  976289 driver_mock.go:47] MockDriver.GetState called from /home/prezha/dev/Kubernetes/minikube/github.com/prezha/minikube/pkg/minikube/tunnel/tunnel.go#119: returning "Running"
--- PASS: TestTunnel (0.00s)
    --- PASS: TestTunnel/simple_stopped (0.00s)
    --- PASS: TestTunnel/tunnel_cleanup_(ctrl+c_before_check) (0.00s)
    --- PASS: TestTunnel/tunnel_create_Route (0.00s)
    --- PASS: TestTunnel/tunnel_cleanup_error_after_1_successful_addRoute (0.00s)
    --- PASS: TestTunnel/tunnel_cleanup (0.00s)
    --- PASS: TestTunnel/race_condition:_other_tunnel_registers_while_in_between_routing_and_registration (0.00s)
    --- PASS: TestTunnel/race_condition:_other_tunnel_registers_and_creates_the_same_route_first (0.00s)
=== RUN   TestErrorCreatingTunnel
I0205 00:45:29.677353  976289 host.go:66] Checking if "testmachine" exists ...
I0205 00:45:29.677357  976289 api_mock.go:60] MockAPI.Load: &{ConfigVersion:0 Driver:0xc0004c9760 DriverName: HostOptions:<nil> Name: RawDriver:[]} - <nil>
I0205 00:45:29.677362  976289 driver_mock.go:47] MockDriver.GetState called from /home/prezha/dev/Kubernetes/minikube/github.com/prezha/minikube/pkg/minikube/tunnel/cluster_inspector.go#62: returning "Stopped"
--- PASS: TestErrorCreatingTunnel (0.00s)
PASS
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.483s

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 5, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 5, 2025
@prezha prezha force-pushed the bumpK8sAPI-v0.32.1 branch from e78d3cf to 7e7f32f Compare February 5, 2025 01:29
@prezha
Copy link
Contributor Author

prezha commented Feb 5, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 5, 2025
@prezha prezha mentioned this pull request Feb 5, 2025
Closed
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20363) |
+----------------+----------+---------------------+
| minikube start | 48.5s    | 50.3s               |
| enable ingress | 15.4s    | 14.6s               |
+----------------+----------+---------------------+

Times for minikube start: 47.5s 47.8s 51.5s 47.3s 48.5s
Times for minikube (PR 20363) start: 50.8s 48.8s 50.3s 49.5s 52.1s

Times for minikube ingress: 14.5s 15.5s 16.0s 15.4s 15.4s
Times for minikube (PR 20363) ingress: 13.9s 14.4s 14.9s 15.0s 15.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20363) |
+----------------+----------+---------------------+
| minikube start | 23.0s    | 22.2s               |
| enable ingress | 12.4s    | 12.8s               |
+----------------+----------+---------------------+

Times for minikube start: 23.6s 23.9s 23.4s 20.8s 23.2s
Times for minikube (PR 20363) start: 21.0s 24.7s 23.6s 21.2s 20.5s

Times for minikube (PR 20363) ingress: 12.8s 13.3s 12.7s 12.3s 12.8s
Times for minikube ingress: 12.3s 12.3s 12.3s 12.3s 12.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20363) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 20.1s               |
| enable ingress | 38.9s    | 36.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 38.8s 38.8s 38.8s 38.8s 39.2s
Times for minikube (PR 20363) ingress: 38.8s 39.2s 39.2s 38.8s 27.3s

Times for minikube start: 22.7s 22.5s 19.6s 19.5s 23.1s
Times for minikube (PR 20363) start: 18.6s 20.5s 18.8s 23.0s 19.6s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_crio (6 failed) TestNetworkPlugins/group/flannel/Start(gopogh) 30.00% (chart)
Docker_Linux_crio (6 failed) TestFunctional/parallel/MySQL(gopogh) 39.13% (chart)
Docker_Linux_crio (6 failed) TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup(gopogh) 39.13% (chart)
Docker_Linux_crio (6 failed) TestFunctional/parallel/TunnelCmd/serial/AccessDirect(gopogh) 39.13% (chart)
Docker_Linux_crio (6 failed) TestFunctional/parallel/PersistentVolumeClaim(gopogh) 43.48% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

@medyagh
Copy link
Member

medyagh commented Feb 7, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2025
@medyagh
Copy link
Member

medyagh commented Feb 7, 2025

thank you @prezha

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, prezha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 00eeee4 into kubernetes:master Feb 7, 2025
30 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

@spowelljr spowelljr Awaiting requested review from spowelljr

Assignees

@medyagh medyagh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prezha @minikube-pr-bot @medyagh @k8s-ci-robot