Skip to content

config.go: invoke the MaskProxyPasswordWithKey function to hide the e… #20222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

config.go: invoke the MaskProxyPasswordWithKey function to hide the e… #20222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/minikube/node/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ func showVersionInfo(k8sVersion string, cr cruntime.Manager) {
out.Infof("opt {{.docker_option}}", out.V{"docker_option": v})
}
for _, v := range config.DockerEnv {
v = util.MaskProxyPasswordWithKey(v)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the long wait on reviewing this PR,
do you mind moving tihs function to the proxy package ?

proxy.MaskProxyPasswordWithKey

there are two Proxy related functions in the util package and need to be moved to proxy package

out.Infof("env {{.docker_env}}", out.V{"docker_env": v})
}
}
Expand Down
Loading