Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: only initiate http2 server options when http2 is not disabled #129538

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Cleanup: only initiate http2 server options when http2 is not disabled #129538

merged 1 commit into from
Jan 20, 2025

Conversation

hzxuzhonghu
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This patch do not bring any behavior change, just a cleanup

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 9, 2025
@k8s-ci-robot k8s-ci-robot requested review from jpbetz and tkashem January 9, 2025 03:31
@hzxuzhonghu
Copy link
Member Author

/sig api-machinery

@hzxuzhonghu hzxuzhonghu changed the title Cleanupï: only initiate http2 server options when http2 is not disabled Cleanup: only initiate http2 server options when http2 is not disabled Jan 9, 2025
@cici37
Copy link
Contributor

cici37 commented Jan 9, 2025

/triage accepted
/assign

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 9, 2025
@cici37
Copy link
Contributor

cici37 commented Jan 9, 2025

/lgtm
/assign @jpbetz
for approval. Thanks :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b86a2292a376841d40ea440e5e34f62cb3ee4ccd

@hzxuzhonghu
Copy link
Member Author

@jpbetz ping

@aojea
Copy link
Member

aojea commented Jan 17, 2025

/lgtm
/approve
/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Jan 20, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, hzxuzhonghu, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2c91535 into kubernetes:master Jan 20, 2025
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 20, 2025
@hzxuzhonghu hzxuzhonghu deleted the http2-clean branch January 20, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz Awaiting requested review from jpbetz

@tkashem tkashem Awaiting requested review from tkashem

Assignees

@jpbetz jpbetz

@liggitt liggitt

@aojea aojea

@cici37 cici37

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
6 participants
@hzxuzhonghu @cici37 @k8s-ci-robot @aojea @liggitt @jpbetz