Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add namespace to DRA adminAccess ValidatingAdmissionPolicy message #129530

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Add namespace to DRA adminAccess ValidatingAdmissionPolicy message #129530

merged 1 commit into from
Jan 8, 2025

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Jan 8, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR adds the namespace to the failure message generated by the example ValidatingAdmissionPolicy for ResourceClaims and ResourceClaimTemplates when adminAccess is forbidden.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 8, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 8, 2025
@nojnhuh nojnhuh mentioned this pull request Jan 8, 2025
Closed
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jan 8, 2025

/cc @pohly

@k8s-ci-robot k8s-ci-robot requested a review from pohly January 8, 2025 17:18
nojnhuh
nojnhuh commented Jan 8, 2025
View reviewed changes
test/e2e/dra/test-driver/deploy/example/admin-access-policy.yaml
@@ -25,7 +25,7 @@ spec:
validations:
- expression: '! object.spec.devices.requests.exists(e, has(e.adminAccess) && e.adminAccess)'
reason: Forbidden
messageExpression: '"admin access to devices not enabled"' # in namespace " + object.metadata.namespace' - need to use __namespace__, but somehow that also doesn't work.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explained the rationale for this change here: #129514 (comment)

@AnishShah
Copy link
Contributor

/cc @bart0sh

pohly
pohly approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

This VAP remains relevant as example for Kubernetes 1.32, so it's worthwhile enhancing it even if 1.33 later starts to use something else.

Thanks @nojnhuh for tracking this down!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 606e4f58ba6c646eee6d682621c1196a74461c54

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit 37a8516 into kubernetes:master Jan 8, 2025
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 8, 2025
@nojnhuh nojnhuh deleted the dra-vap-message branch February 24, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh

@klueska klueska Awaiting requested review from klueska

Assignees

@pohly pohly

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
SIG Node CI/Test Board
Archived in project
SIG Node: Dynamic Resource Allocation
Status: ✅ Done
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
4 participants
@nojnhuh @k8s-ci-robot @AnishShah @pohly