-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(customresourcestate): add example to expose same metrics with different label #2580
base: main
Are you sure you want to change the base?
Conversation
…ferent label Signed-off-by: clavinjune <[email protected]>
Signed-off-by: clavinjune <[email protected]>
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @clavinjune! |
should I create docs to cover #2041? cc @QuentinBisson |
@clavinjune that would be amazing :) |
Signed-off-by: clavinjune <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: clavinjune The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: clavinjune <[email protected]>
Signed-off-by: clavinjune <[email protected]>
Amazing thank you 🚀 |
list: ["Auto", "Initial", "Off", "Recreate"] | ||
# Memory kube_verticalpodautoscaler_spec_resourcepolicy_container_policies_minallowed | ||
- name: "verticalpodautoscaler_spec_resourcepolicy_container_policies_minallowed" | ||
help: "Minimum memory resources the VerticalPodAutoscaler can set for containers matching the name." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to make metric name shorter if it's possible
For example, vpa_policies_minallowed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to make it the same as the previous metrics which are removed, so I made it the same. If we changed the metrics name here, it defeats the purpose to re-expose the removed metrics. The plan is to have no parity between the metrics removed with this guide. wdyt @CatherineF-dev?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inferring the naming based on the Prometheus conventions, and as such, for instance, and taking into consideration Catherine's comment, this may be changed to:
vpa_spec_resourcepolicy_container_policies_minallowed_bytes
However, since the point is to polyfill these metrics, it makes sense to not break the previous names.
I believe it somehow slipped my mind but, I've wanted to contribute the same thing and it's customizable I'll try to diff the config here against the one linked to make sure we didn't miss anything. |
any other thing I should update? |
What this PR does / why we need it: Give an example on how to expose a same metrics with different label (VPA recommendation for example)
How does this change affect the cardinality of KSM: does not change cardinality directly since this is an optional / custom resource state metrics
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #