Skip to content

kubelet: Wait less for control-plane pods to restart #17510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

kubelet: Wait less for control-plane pods to restart #17510

wants to merge 1 commit into from

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 22, 2025

/cc @justinsb @rifelpet @ameukam

/hold for feedback

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hakman
Copy link
Member Author

hakman commented Jul 22, 2025

/test pull-kops-e2e-kubernetes-azure

@hakman hakman force-pushed the maxContainerRestartPeriod branch from eb805d2 to ecd8b8a Compare July 22, 2025 06:35
@hakman
Copy link
Member Author

hakman commented Jul 22, 2025

/test pull-kops-e2e-kubernetes-azure

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2025
@hakman hakman force-pushed the maxContainerRestartPeriod branch from ecd8b8a to e959dba Compare July 22, 2025 07:08
@hakman
Copy link
Member Author

hakman commented Jul 22, 2025

/test pull-kops-e2e-kubernetes-azure

@ameukam
Copy link
Member

ameukam commented Jul 22, 2025

TIL we can introduce alpha features in the kOps API.

@hakman hakman force-pushed the maxContainerRestartPeriod branch from e959dba to 0402ae9 Compare July 22, 2025 10:36
@hakman
Copy link
Member Author

hakman commented Jul 22, 2025

/test pull-kops-e2e-kubernetes-azure

@hakman
Copy link
Member Author

hakman commented Jul 22, 2025

/retest

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2025
justinsb
justinsb reviewed Aug 27, 2025
View reviewed changes
Copy link
Member

@justinsb justinsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea. Unsure whether we should put it into the schema yet, but I'm definitely in favor of setting this on the control plane. (We could also look at an initContainer that waits for our dependencies)

nodeup/pkg/model/kubelet.go
@@ -242,6 +244,9 @@ func buildKubeletComponentConfig(kubeletConfig *kops.KubeletConfigSpec, provider
if providerID != "" {
componentConfig.ProviderID = providerID
}
componentConfig.CrashLoopBackOff = kubelet.CrashLoopBackOffConfig{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: should we mirror the kubelet config structure here (i.e. kubelet.crashLoopBackOff.maxContainerRestartPeriod, instead of kubelet.crashLoopBackOffMaxContainerRestartPeriod)?

nodeup/pkg/model/kubelet.go
if c.FeatureGates == nil {
c.FeatureGates = make(map[string]string)
}
c.FeatureGates["KubeletCrashLoopBackOffMax"] = "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we think KubeletCrashLoopBackOffMax is going to land? Because if we're not sure, we might not want to expose it in the kubelet config yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb left review comments

@ameukam ameukam Awaiting requested review from ameukam

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees
No one assigned
Labels
area/api area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @k8s-ci-robot @ameukam @justinsb