Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #17333

Merged
merged 9 commits into from
Mar 29, 2025
Merged

Update dependencies #17333

merged 9 commits into from
Mar 29, 2025

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Mar 28, 2025 •
edited
Loading

I didnt update k8s.io/kops and k8s.io/release in the tests/e2e module because one of the dependencies is removing the klog command line flags from the kubetest2-kops binary. I'll keep investigating this in a separate PR.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/api area/provider/scaleway Issues or PRs related to Scaleway provider size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 28, 2025
rifelpet
rifelpet commented Mar 28, 2025
View reviewed changes
pkg/testutils/integrationtestharness.go
@@ -90,7 +90,7 @@ func NewIntegrationTestHarness(t *testing.T) *IntegrationTestHarness {

// Generate much smaller keys, as this is often the bottleneck for tests
h.originalPKIDefaultPrivateKeySize = pki.DefaultPrivateKeySize
pki.DefaultPrivateKeySize = 512
pki.DefaultPrivateKeySize = 1024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://pkg.go.dev/crypto/rsa#hdr-Minimum_key_size

@hakman
Copy link
Member

hakman commented Mar 29, 2025 

  go.mod » github.com/containerd/[email protected] – containerd has an integer overflow in User ID handling (moderate severity)
    ↪ https://github.com/advisories/GHSA-265r-hfxg-fhmg
  Error: Dependency review detected vulnerable packages.

@hakman
Copy link
Member

hakman commented Mar 29, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2025
@hakman
Copy link
Member

hakman commented Mar 29, 2025

/override tests-e2e-scenarios-bare-metal

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: tests-e2e-scenarios-bare-metal

In response to this:

/override tests-e2e-scenarios-bare-metal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Member

hakman commented Mar 29, 2025

/override tests-e2e-scenarios-bare-metal

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: tests-e2e-scenarios-bare-metal

In response to this:

/override tests-e2e-scenarios-bare-metal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman hakman merged commit 298e771 into kubernetes:master Mar 29, 2025
26 of 28 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/provider/scaleway Issues or PRs related to Scaleway provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
3 participants
@rifelpet @hakman @k8s-ci-robot