Skip to content

Conversation

jackfrancis
Copy link
Contributor

@jackfrancis jackfrancis commented Jul 25, 2025

Validation tips for PR reviewers:

$ gcloud container images describe gcr.io/k8s-staging-autoscaling/cluster-autoscaler:v1.30.5
WARNING: Successfully resolved tag to sha256, but it is recommended to use sha256 directly.
image_summary:
  digest: sha256:c63b6fc563a7e374fca8fa3ca226d58955fe92360cb93aaa76974fc5dbf5cee6
  fully_qualified_digest: gcr.io/k8s-staging-autoscaling/cluster-autoscaler@sha256:c63b6fc563a7e374fca8fa3ca226d58955fe92360cb93aaa76974fc5dbf5cee6
  registry: gcr.io
  repository: k8s-staging-autoscaling/cluster-autoscaler
$ gcloud container images describe gcr.io/k8s-staging-autoscaling/cluster-autoscaler-amd64:v1.30.5
WARNING: Successfully resolved tag to sha256, but it is recommended to use sha256 directly.
image_summary:
  digest: sha256:a2787ac544fc9abe6157ebe29c0fa89818867abc84fe63ac795b2036cc2d6ad3
  fully_qualified_digest: gcr.io/k8s-staging-autoscaling/cluster-autoscaler-amd64@sha256:a2787ac544fc9abe6157ebe29c0fa89818867abc84fe63ac795b2036cc2d6ad3
  registry: gcr.io
  repository: k8s-staging-autoscaling/cluster-autoscaler-amd64
$ gcloud container images describe gcr.io/k8s-staging-autoscaling/cluster-autoscaler-arm64:v1.30.5
WARNING: Successfully resolved tag to sha256, but it is recommended to use sha256 directly.
image_summary:
  digest: sha256:fb51f088450db4109aac3d228b2ee2fe822097873c20fac39e324285bf5164f2
  fully_qualified_digest: gcr.io/k8s-staging-autoscaling/cluster-autoscaler-arm64@sha256:fb51f088450db4109aac3d228b2ee2fe822097873c20fac39e324285bf5164f2
  registry: gcr.io
  repository: k8s-staging-autoscaling/cluster-autoscaler-arm64
$ gcloud container images describe gcr.io/k8s-staging-autoscaling/cluster-autoscaler-s390x:v1.30.5
WARNING: Successfully resolved tag to sha256, but it is recommended to use sha256 directly.
image_summary:
  digest: sha256:d1dd10b6c14dd1bf67935d7c19bac35982d2b877589bcc67771e8626ea5dfea3
  fully_qualified_digest: gcr.io/k8s-staging-autoscaling/cluster-autoscaler-s390x@sha256:d1dd10b6c14dd1bf67935d7c19bac35982d2b877589bcc67771e8626ea5dfea3
  registry: gcr.io
  repository: k8s-staging-autoscaling/cluster-autoscaler-s390x

E2E validation PR:

Successful test runs:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 25, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 25, 2025
@@ -81,6 +81,7 @@
"sha256:656d21dacb015b8ccfdaec5047963499c10ad6e2598a29c450138c75d533010c": ["v1.32.0"]
"sha256:dfc7e06c58b3757e530a0be1b8af6f6fe38926f0f4da35d6f1b8a9a9e0bb78de": ["v1.32.1"]
"sha256:6ef10d108e0e45ecd883e074682330bbd4a3403e767ad56804800f2f4ee816da": ["v1.33.0"]
"sha256:c63b6fc563a7e374fca8fa3ca226d58955fe92360cb93aaa76974fc5dbf5cee6": ["v1.30.5"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this next to the other 1.30 images so that we keep the list sorted? Same for the other architectures

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@towca
Copy link
Contributor

towca commented Jul 28, 2025

/approve

@towca
Copy link
Contributor

towca commented Jul 28, 2025

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, towca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8258f84 into kubernetes:main Jul 28, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 28, 2025
@jackfrancis jackfrancis deleted the ca-v1.30.5 branch July 28, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants