Skip to content

Add permissions for v1.34 release team leads and subteam leads #8100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add permissions for v1.34 release team leads and subteam leads #8100

wants to merge 1 commit into from

Conversation

Vyom-Yadav
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ area/release-eng Issues or PRs related to the Release Engineering subproject sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels May 14, 2025
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 14, 2025
@Vyom-Yadav Vyom-Yadav mentioned this pull request May 14, 2025
Open
@Vyom-Yadav
Copy link
Member Author

/cc @katcosgrove @fsmunoz

Vyom-Yadav
Vyom-Yadav commented May 15, 2025
View reviewed changes
groups/sig-release/groups.yaml
Comment on lines +377 to +378
- [email protected] # v1.34 EA
- [email protected] # v1.34 Release Lead
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katcosgrove I added myself as a manager of the group, I don't know if I require that access (Nina was a member last cycle), let me know if I don't need it (I added myself based on the pattern), and I'll move myself to the members list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: The current access is correct, it would be discussed later if we should remove EA and Lead.

@wendy-ha18
Copy link
Member

lgtm, thanks Vyom

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Vyom-Yadav, wendy-ha18
Once this PR has been reviewed and has the lgtm label, please assign jeremyrickard for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wendy-ha18 wendy-ha18 removed their assignment May 15, 2025
@Vyom-Yadav
Copy link
Member Author

cc @kubernetes/sig-release-leads, can you please approve this? TIA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendy-ha18 wendy-ha18 wendy-ha18 approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@justaugustus justaugustus Awaiting requested review from justaugustus

@fsmunoz fsmunoz Awaiting requested review from fsmunoz

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

Assignees
No one assigned
Labels
area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vyom-Yadav @wendy-ha18 @k8s-ci-robot