Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support windows hostprocess image build in script #2 #7728

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jan 25, 2025

this is a proceeding fix of #7720
This PR only fixes the smbplugin image build to support windows hostprocess image build, no impact to other images.

/assign @xing-yang

  • mock test with the modified script
# bash test
- name: csi-attacher
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: csi-external-health-monitor-agent
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: csi-external-health-monitor-controller
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: csi-node-driver-registrar
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: csi-provisioner
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: csi-resizer
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: csi-snapshotter
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: hello-populator
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: hostpathplugin
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: iscsiplugin
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: livenessprobe
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: local-volume-provisioner
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: local-volume-node-cleanup
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: mock-driver
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: nfs-provisioner
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: nfs-subdir-external-provisioner
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: nfsplugin
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: objectstorage-controller
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: objectstorage-sidecar
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: smbplugin
  dmap:
tags~^v\d+\.\d+\.\d+(-\w+)*$
- name: snapshot-controller
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: snapshot-validation-webhook
  dmap:
tags~^v\d+\.\d+\.\d+$
- name: volume-data-source-validator
  dmap:
tags~^v\d+\.\d+\.\d+$

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2025
@k8s-ci-robot k8s-ci-robot added the area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects label Jan 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andyzhangx
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants