infra/gcp/release: redo kubernetes ci buckets #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
approved
|
ref: #2318 |
This refactors but also adds a few things: - pull the previous loop body into ensure_kubernetes_ci_gcs_bucket - unroll the loop / remove the array since most of these may go away - add write access for pr-kubekins (the service account used by google.com-owned k8s-prow and k8s-prow-builds) to allow jobs running there to write here; facilitates migration away from gs://kubernetes-release-dev - add gcs access logging for all kubernetes ci buckets to help identify what pr-kubekins is being used to write - add admin access for [email protected] for parity with gs://kubernetes-release-dev
spiffxp
force-pushed
the
redo-kubernetes-ci-buckets
branch
from
527b27b to
eb0a515
Compare
k8s-ci-robot
added
size/L
|
FYI @kubernetes/release-engineering |
justaugustus
approved these changes
Jul 14, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jul 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors but also adds a few things: