-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change oauth redirect to 307 #12646
base: main
Are you sure you want to change the base?
Change oauth redirect to 307 #12646
Conversation
|
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ph0tonic The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @Ph0tonic! |
Hi @Ph0tonic. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
cc69216
to
6ca7488
Compare
What this PR does / why we need it:
OAuth2 is broken for non GET requests due to the way browser handle those. The 302 redirection code lead browsers to loose the original method and replacing it with GET.
This PR will allow to fix the first step to make oauth2 work even for non GET requests.
Types of changes
Which issue/s this PR fixes
Fixes #12636
How Has This Been Tested?
This change has been tested though the officials tests which have been updated.
This change doesn't impact other part of the code, but might be a breaking change for other applications which have hard coded the 302 redirection code. However, change this change will allow to enhance oauth2 protocol to work even for non GET request.
Checklist: