Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2862: Graduate to BETA. #5016

Merged
merged 1 commit into from
Jan 22, 2025
Merged

KEP-2862: Graduate to BETA. #5016

merged 1 commit into from
Jan 22, 2025
+82 −4

Conversation

vinayakankugoyal
Copy link
Contributor

  • One-line PR description: Graduate KEP-2862 to BETA.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 26, 2024
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 26, 2024
@vinayakankugoyal
Copy link
Contributor Author

cc @tallclair

@pacoxu
Copy link
Member

pacoxu commented Jan 2, 2025

/assign @tallclair @liggitt @SergeyKanzhelev

@pacoxu
Copy link
Member

pacoxu commented Jan 2, 2025

/assign @jpbetz
for PRR review

@tallclair
Copy link
Member

Any code changes planned for beta, other than flipping the feature gate?

Moving to beta LGTM

@vinayakankugoyal
Copy link
Contributor Author

Any code changes planned for beta, other than flipping the feature gate?

Moving to beta LGTM

The only code changes I had planned was flipping the feature gate. Thanks!

@vinayakankugoyal vinayakankugoyal mentioned this pull request Jan 15, 2025
Open
11 tasks
@tallclair
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2025
@jpbetz
Copy link
Contributor

jpbetz commented Jan 21, 2025

/approve
For PRR. I appreciate the level of detail on the rollback scenarios. Thanks!

@dchen1107 dchen1107 added this to the v1.33 milestone Jan 22, 2025
@dchen1107
Copy link
Member

/approve based on @jpbetz and @tallclair reviews.

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, jpbetz, vinayakankugoyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4776f2a into kubernetes:master Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@jpbetz jpbetz

@liggitt liggitt

@SergeyKanzhelev SergeyKanzhelev

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
8 participants
@vinayakankugoyal @pacoxu @tallclair @jpbetz @dchen1107 @k8s-ci-robot @liggitt @SergeyKanzhelev