Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WG-Etcd Operator annual report #8296

Merged
merged 3 commits into from
Feb 20, 2025
Merged

WG-Etcd Operator annual report #8296

merged 3 commits into from
Feb 20, 2025

Conversation

jberkus
Copy link
Contributor

@jberkus jberkus commented Jan 24, 2025

Most of the annual report for Etcd Operator working group. A few things missing:

  1. Where can I put a link to our repository in sigs.yaml? I don't see a field for repos.
  2. Since our WG was created in 2024, do we need to have status meetings with our sponsoring SIGs?
  3. I couldn't find the Operator Workflow doc, @ahrtr link to that?

attn: @soltysh @justinsb @jmhbnz

@k8s-ci-robot k8s-ci-robot added the area/annual-reports Issues or PRs related to the annual reports label Jan 24, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 24, 2025
@jberkus
Copy link
Contributor Author

jberkus commented Jan 24, 2025

/sig etcd
/sig cluster-lifecycle
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Jan 24, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 25, 2025
@jberkus
Copy link
Contributor Author

jberkus commented Jan 25, 2025

OK, added info about the repository in the description, because there's nowhere else for it to go. Also added repo/subproject etcd-operator to the SIG-etcd readme, since ultimately the SIG owns that repo.

resolves #8280

ahrtr
ahrtr reviewed Jan 25, 2025
View reviewed changes
sig-etcd/README.md
@@ -90,6 +90,10 @@ Distributed reliable key-value store for the most critical data of a distributed
etcd manager
- **Owners:**
- [kubernetes-sigs/etcd-manager](https://github.com/kubernetes-sigs/etcd-manager/blob/main/OWNERS)
### etcd-operator
future site of the new etcd operator, currently used for wg-etcd-operator artifacts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
future site of the new etcd operator, currently used for wg-etcd-operator artifacts
The official Kubernetes operator for etcd.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably that only becomes true when we finish the build and it turns into the etcd-operator subproject.

sigs.yaml
@@ -1805,6 +1805,11 @@ sigs:
description: etcd manager
owners:
- https://raw.githubusercontent.com/kubernetes-sigs/etcd-manager/main/OWNERS
- name: etcd-operator
description: future site of the new etcd operator, currently used for wg-etcd-operator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: future site of the new etcd operator, currently used for wg-etcd-operator
description: The official Kubernetes operator for etcd.

@ahrtr
Copy link
Member

ahrtr commented Jan 25, 2025

2. Since our WG was created in 2024, do we need to have status meetings with our sponsoring SIGs?

Both sig-etcd and sig-clusterlifecyle leads join our wg meeting, so personally I don't think we need a separate status meeting. But it's up to all leads of both sigs.

3. I couldn't find the Operator Workflow doc, @ahrtr link to that?

As mentioned in #8296 (comment), let me deliver a PR to add the design doc into the repo next week.

soltysh
soltysh approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, other wise this lgtm

/approve
/hold
so it gets the necessary visibility, feel free to drop the hold once you reach consensus

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2025
@jberkus
Changes per PR feedback.
79965ab 
Signed-off-by: Josh Berkus <[email protected]>
@jberkus
Copy link
Contributor Author

jberkus commented Feb 16, 2025

Pushed changes per feedback above. Did not change the description of the etcd-operator repository per my note above.

@ahrtr
Copy link
Member

ahrtr commented Feb 16, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jberkus, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor

soltysh commented Feb 20, 2025

I believe this is good as is.
/hold cancel
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 818f0a6 into kubernetes:master Feb 20, 2025
3 checks passed
@soltysh soltysh mentioned this pull request Feb 20, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr left review comments

@soltysh soltysh soltysh approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

Assignees

@ahrtr ahrtr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/annual-reports Issues or PRs related to the annual reports cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jberkus @ahrtr @k8s-ci-robot @soltysh