Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve frequent loops when only one of activities is productive #7679

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Improve frequent loops when only one of activities is productive #7679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions cluster-autoscaler/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,10 +670,13 @@ func run(healthCheck *metrics.HealthCheck, debuggingSnapshotter debuggingsnapsho

// Autoscale ad infinitum.
if *frequentLoopsEnabled {
// We need to have two timestamps because the scaleUp activity alternates between processing ProvisioningRequests,
// so we need to pass the older timestamp (previousRun) to trigger.Wait to run immediately if only one of the activities is productive.
lastRun := time.Now()
previousRun := time.Now()
for {
trigger.Wait(lastRun)
lastRun = time.Now()
trigger.Wait(previousRun)
previousRun, lastRun = lastRun, time.Now()
loop.RunAutoscalerOnce(autoscaler, healthCheck, lastRun)
}
} else {
Expand Down
Loading