Make ContainerD logs to file #512
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zylxjtu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XL
|
@zylxjtu - can we remove the KPNG stuff as a separate PR? |
| } | ||
| containerd.exe --version | ||
| containerd-shim-runhcs-v1.exe --version | ||
| - content: "$ErrorActionPreference = 'Stop'\n$$CONTAINERD_URL=\"${WINDOWS_CONTAINERD_URL}\"\nif($$CONTAINERD_URL |
There was a problem hiding this comment.
do we know why the formatting is getting mangled now in the generated templates?
There was a problem hiding this comment.
no, I have tried to remove the "\n" but it does not seem to make much difference. so I'm guessing this is the issue of diff instead of real ones?
|
|
||
| # apply additional helper manifests (logger etc) | ||
| kubectl apply -f "${CAPZ_DIR}"/templates/addons/windows/containerd-logging/containerd-logger.yaml | ||
| if [[ -n "$CONTAINERD_LOGGER" ]]; then |
There was a problem hiding this comment.
This is now optional but is the intention to continue running the containerd logger?
IIRC it also logs ETW events for HCS which can be useful in debugging which containerd doesn't log.
@jsturtevant WDYT of these changes?
There was a problem hiding this comment.
No, the intent is to remove this logger pod if we have can have containerd log to files.
There was a problem hiding this comment.
I think we'll potentially miss some etw events from HCS / Windows.
Are we OK with that?
I will move this to a separate PR |
capz/templates/gmsa-ci.yaml
Outdated
| template: | ||
| spec: | ||
| additionalTags: | ||
| AzSecPackAutoConfigReady: "true" |
There was a problem hiding this comment.
I guess this can be removed, not applicable universally
k8s-ci-robot
added
size/L
|
@zylxjtu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
No description provided.