Fix ExtractItems duplication with WithAppendKeyFields #295
+98
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ExtractItems
withWithAppendKeyFields
no longer duplicates list items when extracting both item keys and specific fields.Why
When extracting from associative lists with paths like:
The item with uid="123" was appearing twice in the output.
Changes
doList
intyped/remove.go
to process items only once when both item path and field paths are presentExample
When extracting with fieldpaths:
.metadata.labels["app"]
.metadata.labels["version"]
.metadata.labels["env"]
.metadata.ownerReferences[uid="123e4567-e89b-12d3-a456-426614174000"]
Before fix - ownerReference was duplicated:
After fix - ownerReference appears only once: