Skip to content

add an embeddable demo to README #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ajaysundark wants to merge 0 commits into from
Closed

add an embeddable demo to README #25

ajaysundark wants to merge 0 commits into from
+0 −0

Conversation

@ajaysundark
Copy link
Contributor

@ajaysundark ajaysundark commented Dec 8, 2025

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 8, 2025
@ajaysundark
Copy link
Contributor Author

ajaysundark commented Dec 8, 2025

/hold

@sreeram-venkitesh found an issue where our kind testing has a mismatch from the documentation. I need to check if this demo needs another revision.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2025
@ajaysundark ajaysundark mentioned this pull request Dec 8, 2025
Merged
@ajaysundark
Copy link
Contributor Author

ajaysundark commented Dec 8, 2025

I'll continue this once #27 is merged to ensure I capture the resource names correctly.

cc @Karthik-K-N

@ajaysundark ajaysundark force-pushed the main branch 2 times, most recently from 9779ed5 to 0c9cc2c Compare December 9, 2025 08:39
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 9, 2025
@ajaysundark ajaysundark closed this Dec 9, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ajaysundark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 9, 2025
@ajaysundark
Copy link
Contributor Author

ajaysundark commented Dec 9, 2025

new PR #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Priyankasaggu11929 Priyankasaggu11929 Awaiting requested review from Priyankasaggu11929

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add demo GIF to README

2 participants

@ajaysundark @k8s-ci-robot