Skip to content

Updated node type in testing doc, updated readme #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 3 commits into from
Dec 18, 2025
Merged

Updated node type in testing doc, updated readme #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6be516
Updated node type in testing doc, updated readme
sreeram-venkitesh Dec 7, 2025
1722ce5
Updated test_readme.md to reflect controller running on control plane…
sreeram-venkitesh Dec 18, 2025
c01f32c
Typo: nrg -> nrr
sreeram-venkitesh Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ spec:
node-role.kubernetes.io/worker: ""
```

Find a more detailed walkthrough of setting up Node Readiness Controller in your Kind cluster [here](https://github.com/kubernetes-sigs/node-readiness-controller/blob/main/docs/TEST_README.md).

## High-level Roadmap

- [ ] Add documentation capturing design details
Expand Down
6 changes: 3 additions & 3 deletions docs/TEST_README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ The test demonstrates a realistic, production-aligned scenario where critical ad
### Test Topology

The test uses a 3-node Kind cluster:
1. **`nrr-test-control-plane`**: The Kubernetes control plane.
2. **`nrr-test-worker` (Platform Node)**: A dedicated node for running cluster-critical addons. It is labeled `reserved-for=platform` and has a corresponding taint to repel normal application workloads. Cert-manager and the NRR controller will run here.
1. **`nrr-test-control-plane`**: The Kubernetes control plane. The NRR controller will run here unless specifically configured.
2. **`nrr-test-worker` (Platform Node)**: A dedicated node for running cluster-critical addons. It is labeled `reserved-for=platform` and has a corresponding taint to repel normal application workloads. Cert-manager will run here.
3. **`nrr-test-worker2` (Application Node)**: A standard worker node that starts with a `readiness.k8s.io/NetworkReady=pending:NoSchedule` taint, simulating a node that is not yet ready for application traffic.

## Running the Test
Expand Down Expand Up @@ -53,7 +53,7 @@ Deploy the controller image to nrr-test-worker
make deploy IMG_PREFIX=controller IMG_TAG=latest
```

Verify the controller is running on the platform node (`nrr-test-worker`):
Verify the controller is running on the control plane node (`nrr-test-control-plane`):
```bash
kubectl get pods -n nrr-system -o wide
```
Expand Down