Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests to reflect newAPI changes #214

Merged

Conversation

tssurya
Copy link
Contributor

@tssurya tssurya commented Mar 28, 2024

We fixed the peer API to be symmetric to the subject API via #196

Let's change this to also reflect on the test cases.

So change:

- namespaces:
        namespaceSelector:
          matchLabels:

to

- namespaces:
          matchLabels:

in peers everywhere

Signed-off-by: Surya Seetharaman <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 28, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 28, 2024
Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
🔨 Latest commit 815e22c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/66057df41028c6000859043f
😎 Deploy Preview https://deploy-preview-214--kubernetes-sigs-network-policy-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tssurya
Copy link
Contributor Author

tssurya commented Mar 28, 2024

I am testing this on ovnk once I make the related changes there. hold.

@tssurya
Copy link
Contributor Author

tssurya commented Apr 2, 2024

ran this against: ovn-kubernetes/ovn-kubernetes#4245 which consumes the new syntax for namespace peers and its working.

PASS
ok      sigs.k8s.io/network-policy-api/conformance      376.320s

looks fine; let's merge

@astoycos
Copy link
Member

astoycos commented Apr 2, 2024

/lgtm
/approve

Thanks @tssurya!!!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 648d15c into kubernetes-sigs:main Apr 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants