Skip to content

WIP: TEST KPA experimental install #4941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: TEST KPA experimental install #4941

wants to merge 1 commit into from
+328 −24

Conversation

@camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Jul 20, 2025 •
edited
Loading

REF:#4809

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 20, 2025
@camilamacedo86 camilamacedo86 mentioned this pull request Jul 20, 2025
Open
@camilamacedo86 camilamacedo86 force-pushed the add-kpal-linter-otherway branch 3 times, most recently from 444bd36 to 6bda013 Compare July 20, 2025 19:57
JoelSpeed
JoelSpeed reviewed Jul 21, 2025
View reviewed changes
docs/book/src/getting-started/testdata/project/.golangci.yml Outdated
custom:
kubeapilinter:
type: "module"
description: Kube API LInter lints Kube like APIs based on API conventions and best practices.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to add a settings key below this to add the KAL specific settings

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean:

      settings:
        linters: {}
        lintersConfig: {}

If I add it I face issues as well saying that those properties are invalid

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have the specific error messages?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Running golangci-lint custom...
"/home/runner/work/kubebuilder/kubebuilder/docs/book/src/getting-started/testdata/project/bin/golangci-lint-kube-api" config verify
jsonschema: "" does not validate with "/additionalProperties": additional properties 'linters-settings', 'exclusions' not allowed
The command is terminated due to an error: the configuration contains invalid elements
make: *** [Makefile:103: lint-config] Error 3
Error: Process completed with exit code 2.

@camilamacedo86 camilamacedo86 force-pushed the add-kpal-linter-otherway branch 8 times, most recently from 85696c0 to 2f745c5 Compare July 25, 2025 10:36
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2025
@camilamacedo86 camilamacedo86 force-pushed the add-kpal-linter-otherway branch from 2f745c5 to 6a5c28f Compare October 29, 2025 15:26
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2025
@camilamacedo86 camilamacedo86 force-pushed the add-kpal-linter-otherway branch from 6a5c28f to 96e5382 Compare October 29, 2025 16:36
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2025
@camilamacedo86 camilamacedo86 force-pushed the add-kpal-linter-otherway branch from 96e5382 to ecd247e Compare October 29, 2025 17:05
@camilamacedo86 camilamacedo86 force-pushed the add-kpal-linter-otherway branch from ecd247e to 8fcd00e Compare October 29, 2025 17:55
@k8s-ci-robot k8s-ci-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 29, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 29, 2025
@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubebuilder-e2e-k8s-1-34-1 2f745c5 link true /test pull-kubebuilder-e2e-k8s-1-34-1
pull-kubebuilder-e2e-k8s-1-34-0 8fcd00e link true /test pull-kubebuilder-e2e-k8s-1-34-0
pull-kubebuilder-e2e-k8s-1-33-0 8fcd00e link true /test pull-kubebuilder-e2e-k8s-1-33-0
pull-kubebuilder-e2e-k8s-1-32-0 8fcd00e link true /test pull-kubebuilder-e2e-k8s-1-32-0

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kavinjsir Kavinjsir Awaiting requested review from Kavinjsir

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

1 more reviewer

@JoelSpeed JoelSpeed JoelSpeed left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camilamacedo86 @k8s-ci-robot @JoelSpeed