-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for nftables counter objects #21
Conversation
/assign @aojea @danwinship |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the idea in principle but it would be good to see how it's actually going to get used (ie, not just a WIP/PoC) to make sure we've got it right.
fc865a6
to
1087584
Compare
I have tried to expose a metric using nftables counter, which tracks the number of reject packets destined for invalid ports of the ClusterIPs. |
are we giving up on nfacct due to lack of support on some platforms? |
Signed-off-by: Daman Arora <[email protected]>
1087584
to
53ae89b
Compare
it seems counters is the replacement of nfacct in nftables https://wiki.nftables.org/wiki-nftables/index.php/Supported_features_compared_to_xtables#nfacct |
We can still use nfacct for iptables ( just in case we want to track something ). |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aroradaman, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds support for native named nftables counters.
https://wiki.nftables.org/wiki-nftables/index.php/Counters
Fixes: #20
Sample Usage:
kubernetes/kubernetes#129505
Output (kind):