Skip to content

Conversation

nirrozenbaum
Copy link
Contributor

InferenceModel no longer exists. this section is no longer relevant

Copy link

netlify bot commented Aug 17, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 32592e6
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68a19c8adb4aaf0008e1afb1
😎 Deploy Preview https://deploy-preview-1389--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g August 17, 2025 09:10
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 17, 2025
@k8s-ci-robot k8s-ci-robot requested a review from kfswain August 17, 2025 09:10
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 17, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Aug 17, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5b4fbb9 into kubernetes-sigs:main Aug 17, 2025
9 checks passed
@kfswain
Copy link
Collaborator

kfswain commented Aug 17, 2025

Should we consider instead marking the status as Obsolete? I'm wondering if we want to leave the proposals mostly untouched to somewhat be able to track the past decisions we made. I'm not feeling strongly one way or another, but that keeps us from having to keep old proposals up-to-date

@nirrozenbaum nirrozenbaum deleted the epp-protocol branch August 17, 2025 20:12
@nirrozenbaum
Copy link
Contributor Author

Should we consider instead marking the status as Obsolete? I'm wondering if we want to leave the proposals mostly untouched to somewhat be able to track the past decisions we made. I'm not feeling strongly one way or another, but that keeps us from having to keep old proposals up-to-date

my intuition is that keeping obsolete information here can lead to a big file with obsolete sections that take the focus from the main points of the protocol and makes it hard for a reader to understand what the protocol is.

but I think you're touching a good point - I treated this doc as the place where we hold the most up to date EPP protocol.
that is not true for other proposals, cause most of the proposals result in code.

we do have PR #1360 that should somewhat keep history (executive summary history, only title of a change).
and we always have the history in github.
I think that should be enough at this point, but not feeling strongly one way or another.
feel free to spin up a new issue if you think we should address this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants