Skip to content

Add makefile entries for api-lint #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Aug 14, 2025

This PR adds the makefile entries for Kube api linter, as discussed during WG Inference meeting.

The linter now can be called locally using make verify or make api-lint.

A lint-fix wasn't added, as it is expected that the fixes are discussed and not automatically fixed.

Fixes: #1380

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2025
Copy link

netlify bot commented Aug 14, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 2ab6082
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/689f6191f20df60007b8d014
😎 Deploy Preview https://deploy-preview-1384--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot requested review from ahg-g and danehans August 14, 2025 21:26
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rikatz
Once this PR has been reviewed and has the lgtm label, please assign kfswain for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 14, 2025
@rikatz
Copy link
Contributor Author

rikatz commented Aug 14, 2025

/hold

I will submit a broken change just to guarantee KAL is running

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2025
@rikatz
Copy link
Contributor Author

rikatz commented Aug 14, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2025
@BenTheElder
Copy link
Member

Maybe make the CI use this so you know local and CI invocations are in sync?

@rikatz
Copy link
Contributor Author

rikatz commented Aug 15, 2025

Maybe make the CI use this so you know local and CI invocations are in sync?

hey Ben, the verify-main prow job uses it, but good catch. I will change the github action one to use make api-lint instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a makefile target to run kubeapilinter
3 participants