-
Notifications
You must be signed in to change notification settings - Fork 140
Add makefile entries for api-lint #1384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rikatz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold I will submit a broken change just to guarantee KAL is running |
a13a60e
to
384a5f7
Compare
/hold cancel |
Maybe make the CI use this so you know local and CI invocations are in sync? |
hey Ben, the verify-main prow job uses it, but good catch. I will change the github action one to use |
cac8206
to
cab983e
Compare
cab983e
to
2ab6082
Compare
This PR adds the makefile entries for Kube api linter, as discussed during WG Inference meeting.
The linter now can be called locally using
make verify
ormake api-lint
.A lint-fix wasn't added, as it is expected that the fixes are discussed and not automatically fixed.
Fixes: #1380