Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charts: add needed perms if metricsCollector is enabled #1599

Merged
merged 1 commit into from
Jan 10, 2025
Merged

charts: add needed perms if metricsCollector is enabled #1599

merged 1 commit into from
Jan 10, 2025

Conversation

linuxmaniac
Copy link
Contributor

fixes #1597

E0103 12:37:27.584970       1 metricscollector.go:128] "Error fetching metrics" err="nodes.metrics.k8s.io \"k3s-node3\" is forbidden: User \"system:serviceaccount:kube-system:descheduler\" cannot get resource \"nodes\" in API group \"metrics.k8s.io\" at the cluster scope" node="k3s-node3"

@k8s-ci-robot k8s-ci-robot requested review from a7i and JaneLiuL January 3, 2025 20:59
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @linuxmaniac. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 3, 2025
@linuxmaniac linuxmaniac force-pushed the vseva/1597 branch 2 times, most recently from b5414dc to 4689b93 Compare January 3, 2025 21:42
@a7i
Copy link
Contributor

a7i commented Jan 3, 2025

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 4, 2025
a7i
a7i reviewed Jan 4, 2025
View reviewed changes
@cayla cayla mentioned this pull request Jan 7, 2025
Closed
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
@a7i
Copy link
Contributor

a7i commented Jan 8, 2025

/retest-required

1 similar comment
@a7i
Copy link
Contributor

a7i commented Jan 9, 2025

/retest-required

@googs1025
Copy link
Member

sorry, the ci failed cause by this #1605
please repull branch

@a7i
Copy link
Contributor

a7i commented Jan 10, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1a49e11 into kubernetes-sigs:master Jan 10, 2025
7 checks passed
a7i
a7i reviewed Jan 10, 2025
View reviewed changes
charts/descheduler/values.yaml
Comment on lines +99 to +100
# metricsCollector:
# enabled: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this?

Suggested change
# metricsCollector:
# enabled: true

/hold

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? This option was missing from the example no?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2025
@linuxmaniac linuxmaniac deleted the vseva/1597 branch January 10, 2025 14:01
@googs1025
Copy link
Member

can we cherry pick this commit. this seem to be fix
@a7i @linuxmaniac 🤔

This was referenced Jan 26, 2025
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request Feb 2, 2025
@k8s-ci-robot
Merge pull request #1620 from googs1025/automated-cherry-pick-of-#159…
a6e0ebf 
…9-upstream-release-1.32

Automated cherry pick of #1599: charts: add needed perms if metricsCollector is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7i a7i a7i left review comments

@JaneLiuL JaneLiuL Awaiting requested review from JaneLiuL

Assignees

@a7i a7i

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

charts: missing perms in ClusterRole if metricsCollector.enabled is true
4 participants
@linuxmaniac @k8s-ci-robot @a7i @googs1025