- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.2k
✨ envtest: respect pre-configured binary paths in ControlPlane #3372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
✨ envtest: respect pre-configured binary paths in ControlPlane #3372
Conversation
This commit fixes an issue where Environment.Start() would ignore pre-configured binary paths (APIServer.Path, Etcd.Path, KubectlPath) set in ControlPlane when DownloadBinaryAssets is false. Changes: - Extract path configuration logic into configureBinaryPaths() method for better testability and separation of concerns - Only auto-configure binary paths when they are empty (not pre-set) - When DownloadBinaryAssets is true, downloaded paths are still used (preserving existing behavior) - Update ControlPlane field documentation to clarify path behavior - Add tests in envtest_test.go to verify path handling logic
| [APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mzhaom The full list of commands accepted by this bot can be found here. 
Needs approval from an approver in each of these files:
 Approvers can indicate their approval by writing  | 
| Welcome @mzhaom!  | 
| Hi @mzhaom. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with  Once the patch is verified, the new status will be reflected by the  I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. | 
| /ok-to-test | 
This commit fixes an issue where Environment.Start() would ignore pre-configured binary paths (APIServer.Path, Etcd.Path, KubectlPath) set in ControlPlane when DownloadBinaryAssets is false.
Changes:
This fixed issue #3373