Skip to content

🌱 Clarify our versioning scheme #3264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025

Conversation

alvaroaleman
Copy link
Member

@alvaroaleman alvaroaleman commented Jul 26, 2025

While its technically true that we do semver because semver allow to do anything for as long as a major version zero is used, referring to it doesn't really explain our versioning scheme. Clarify that in the readme and also mention why we won't publish a major version > 0.

Closes #601

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 26, 2025
@k8s-ci-robot k8s-ci-robot requested a review from FillZpp July 26, 2025 16:57
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2025
@k8s-ci-robot k8s-ci-robot requested a review from joelanford July 26, 2025 16:57
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 26, 2025
@alvaroaleman alvaroaleman requested a review from sbueringer July 26, 2025 17:00
@alvaroaleman
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2025
While its technically true that we do semver because semver allow to do
anything for as long as a major version zero is used, referring to it
doesn't really explain our versioning scheme. Clarify that in the readme
and also mention why we won't publish a major version > 0.
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

Leaving the hold to you

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2854566cc13578a9a3e010f086ef85601eb373ea

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alvaroaleman
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 45f797b into kubernetes-sigs:main Jul 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

controller-runtime versioning
3 participants