Fix reconciliation logic for existing and deleted objects #89
+248
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses two cases: - Controller Restarts: When the controller restarts, it does not handle deletions for removed objects. Specifically, when an object with a deletion timestamp is passed into the Add() method, the deletion process was not handled correctly. - Recreation of Objects: The recreation of objects is not functioning as expected. For example, when an object is created, deleted, and then created again. In this scenario, the object may enter the Update method, where the creation process was not being handled properly. Signed-off-by: Andrei Kvapil <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for container-object-storage-interface ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
size/L
|
/assign @shanduur |
kvaps
added a commit
to cozystack/cozystack
that referenced
this pull request
Jul 17, 2025
Signed-off-by: Andrei Kvapil <[email protected]> <!-- Thank you for making a contribution! Here are some tips for you: - Start the PR title with the [label] of Cozystack component: - For system components: [platform], [system], [linstor], [cilium], [kube-ovn], [dashboard], [cluster-api], etc. - For managed apps: [apps], [tenant], [kubernetes], [postgres], [virtual-machine] etc. - For development and maintenance: [tests], [ci], [docs], [maintenance]. - If it's a work in progress, consider creating this PR as a draft. - Don't hesistate to ask for opinion and review in the community chats, even if it's still a draft. - Add the label `backport` if it's a bugfix that needs to be backported to a previous version. --> ## What this PR does This PR updates COSI image and also includes these fixes: - kubernetes-sigs/container-object-storage-interface#89 - kubernetes-sigs/container-object-storage-interface#90 ### Release note <!-- Write a release note: - Explain what has changed internally and for users. - Start with the same [label] as in the PR title - Follow the guidelines at https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md. --> ```release-note [objectstorage] Update COSI controller and sidecar ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Introduced automated image building and version injection for the object storage controller, including support for both controller and sidecar images. * Added comprehensive Kubernetes CustomResourceDefinitions (CRDs) for object storage resources, including Bucket, BucketClaim, BucketClass, BucketAccess, and BucketAccessClass. * Added a dedicated namespace and updated resource naming conventions for improved clarity and consistency. * **Bug Fixes** * Improved and unified deletion handling for object storage resources, ensuring proper cleanup and event recording. * **Chores** * Updated configuration and deployment manifests to use new image locations and naming conventions. * Added a configuration file for specifying the controller image used in deployments. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kvaps, shanduur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplement kubernetes-retired/container-object-storage-interface-provisioner-sidecar#139
This PR addresses two cases:
Controller Restarts:
When the controller restarts, it does not handle deletions for removed objects.
Specifically, when an object with a deletion timestamp is passed into the Add() method, the deletion process was not handled correctly.
Recreation of Objects:
The recreation of objects is not functioning as expected. For example, when an object is created, deleted, and then created again.
In this scenario, the object may enter the Update method, where the creation process was not being handled properly.
Signed-off-by: Andrei Kvapil [email protected]