-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Skipping test that is failing because of infra issues #12496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test ? |
@adilGhaffarDev: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-e2e-main-gke |
062821e
to
862f1f9
Compare
862f1f9
to
d7407a7
Compare
d7407a7
to
be07107
Compare
/test capi-kubernetes-kind-network-ipv6 |
/test pull-cluster-api-e2e-main-gke |
We also need to clone the kind repo in the test YAML, I will open the PR to do that. |
No, I think this line is not needed in the yaml: |
@sbueringer , please check: kubernetes/test-infra#35239 |
/test pull-cluster-api-e2e-main-gke |
/test capi-kubernetes-kind-network-ipv6 |
Yeah, that is what I expected, now the job is running CAPI tests instead of kind tests |
@adilGhaffarDev Can you try to set Like this extra_refs:
- org: kubernetes-sigs
repo: kind
base_ref: main
path_alias: sigs.k8s.io/kind
workdir: true |
I think |
Okay looked up the job. Agree. There should be no need to even clone the kind repo? |
agree, I have updated the PR: kubernetes/test-infra#35240 |
/test capi-kubernetes-kind-network-ipv6 |
Hm, two tests cases are failing. Are we sure we are running the same tests? I'm missing the "[Feature:IPv6DualStack]" prefix |
failures are similar, both fail when In CAPI test failure is at following line: And in case of kind it fails at: I think if we change IP_FAMILY to |
I mean it seems like we are not running the same test? I thought in testgrid I saw the exact same test case/name |
We copied the PR job and it seems PR job is not running exact same test. |
No worries, thx! |
/test capi-kubernetes-kind-network-dual |
@adilGhaffarDev: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Okay. Now we have the exact same error Given that the error also occurs with kind, I would skip this test in our e2e tests. I think that should be possible via skip in https://github.com/kubernetes-sigs/cluster-api/blob/35c260655f40bf1bebde234e41fb15b36d364550/test/e2e/data/kubetest/dualstack.yaml#L1-L0 I would try to only exactly skip |
I can do it. |
Sounds good. Thank you! |
Signed-off-by: Muhammad Adil Ghaffar <[email protected]>
be07107
to
903c7bf
Compare
/test pull-cluster-api-e2e-main |
What this PR does / why we need it:
Skipping Test:
[Feature:IPv6DualStack] Granular Checks: Services Secondary IP Family [LinuxOnly] should function for service endpoints using hostNetwork
This test is being skipped because it consistently fails on EKS clusters.
It also fails in Kind when running on EKS. However, when running on GKE, the same test passes in both Kind and CAPI.
Since we cannot move CAPI jobs to GKE at this time, we are skipping the test in CAPI e2e for now.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #