🐛 Fix OpenStackServer reconciliation stuck when cluster is unpaused #2833
Conversation
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
| // Don't handle deleted clusters | ||
| if !c.DeletionTimestamp.IsZero() { | ||
| log.V(4).Info("Cluster has a deletion timestamp, skipping mapping.") | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Don't we need to clean up if it is deleting? I am thinking that there could be a situation where the user paused the cluster, then deleted (forgetting to unpause first), then unpause.
There was a problem hiding this comment.
hmm, to address this edge case, here's what I did:
I've moved the pause check after the deletion timestamp check (similar to OpenStackCluster controller). Now the reconciliation flow is:
- Check if server is being deleted -> proceed with deletion (regardless of pause state)
- If not deleted, check if cluster is paused -> skip reconciliation
- Otherwise, proceed normally
This ensures deletion always proceeds even if the cluster was paused when deletion started, then later unpaused.
Signed-off-by: Bharath Nallapeta <[email protected]>
bnallapeta
force-pushed
the
pause-2824
branch
from
dd01cc9 to
828af4f
Compare
4 participants
What this PR does / why we need it:
When a cluster is paused (e.g., during a pivot operation), OpenStackServer resources stop reconciling. However, when the cluster is unpaused, they don't resume because the controller doesn't watch for cluster pause/unpause events.
This PR adds a watch on Cluster resources so OpenStackServers are re-queued when their parent cluster transitions from paused to unpaused state.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2824
TODOs:
/hold