-
Notifications
You must be signed in to change notification settings - Fork 440
AzureMachinePoolMachine: avoid setting FailureReason/FailureMessage #5558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
field will get deprecated in v1beta2, setting this currently avoids the Machine from being reconciled at all which does not make sense in this case because a Failed provisioningState is not necessarily terminal
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mweibel. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5558 +/- ##
==========================================
+ Coverage 52.86% 52.87% +0.01%
==========================================
Files 272 272
Lines 29474 29472 -2
==========================================
+ Hits 15582 15584 +2
+ Misses 13080 13076 -4
Partials 812 812 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/ok-to-test |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Field will get deprecated in v1beta2, setting this currently avoids the Machine from being reconciled at all which does not make sense in this case because a Failed provisioningState is not necessarily terminal
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5303
TODOs:
Release note: