-
Notifications
You must be signed in to change notification settings - Fork 440
fix: support ClusterCacheTracker #5556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
POD_UID is required for clusterCacheTracker to work
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mweibel. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5556 +/- ##
=======================================
Coverage 52.86% 52.86%
=======================================
Files 272 272
Lines 29474 29474
=======================================
Hits 15582 15582
Misses 13080 13080
Partials 812 812 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/lgtm |
LGTM label has been added. Git tree hash: 7cfe2c109384f078b2f4646a12e5eb456de13b29
|
/ok-to-test |
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
ClusterCacheTracker is only enabled if POD_NAME, POD_NAMESPACE, and POD_UID are set.
https://github.com/kubernetes-sigs/cluster-api/blob/5815de795489c3edfca22a2c35cd87d7143d9545/controllers/clustercache/cluster_cache.go#L283-L296
TODOs:
Release note: