[release-1.29] Fix : Enable system tag support prefix match #8150
+82
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
In the logic for updating tags, if we define
systemTags
, any tags not included insystemTags
will be deleted. However, this behavior can cause some AKS-managed tags to be mistakenly deleted. Adding all AKS-managed tags individually tosystemTags
would makesystemTags
excessively long and difficult to maintain.This PR enhances the comparison logic between tags and
systemTags
by introducing prefix matching. With this change, we can add a prefix likeaks-managed
tosystemTags
, and any tags starting withaks-managed
, such asaks-managed-cluster-name
oraks-managed-cluster-rg
, will be successfully matched and retained, preventing accidental deletion.This approach reduces the size of
systemTags
while maintaining flexibility and ensuring that AKS-managed tags are preserved.Which issue(s) this PR fixes:
Fixes #8053
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: